Skip to content

Fix base image inconsistency in reprobuild for noble & resolute#9185

Open
ShahanaFarooqui wants to merge 1 commit into
ElementsProject:masterfrom
ShahanaFarooqui:debootstrap-images
Open

Fix base image inconsistency in reprobuild for noble & resolute#9185
ShahanaFarooqui wants to merge 1 commit into
ElementsProject:masterfrom
ShahanaFarooqui:debootstrap-images

Conversation

@ShahanaFarooqui
Copy link
Copy Markdown
Collaborator

cln-repro-* images use minimal debootstrapped base images (jammy, noble, resolute) with additional layers from contrib/reprobuild/. Currently, Dockerfile.noble and Dockerfile.resolute incorrectly pull from ubuntu:noble and ubuntu:resolute instead of using the debootstrapped noble and resolute base images, breaking consistency with Dockerfile.jammy. This PR corrects the base images for noble and resolute. No changes needed for jammy.

Changelog-None.

@ShahanaFarooqui ShahanaFarooqui requested a review from cdecker as a code owner June 3, 2026 04:06
@ShahanaFarooqui ShahanaFarooqui requested review from Lagrang3 and daywalker90 and removed request for cdecker June 3, 2026 04:06
@ShahanaFarooqui ShahanaFarooqui changed the title docker: Fix base image inconsistency in reprobuild for noble & resolute Fix base image inconsistency in reprobuild for noble & resolute Jun 3, 2026
@daywalker90
Copy link
Copy Markdown
Collaborator

I tried to run contrib/cl-repro.sh with this but now i get an error that it can't find the lowdown package (both noble and resolute). I think it's because the apt sources are not configured for universe where lowdown is located: https://packages.ubuntu.com/noble/lowdown

@daywalker90
Copy link
Copy Markdown
Collaborator

Can we just add universe? It works for me after doing this:

diff --git a/contrib/reprobuild/Dockerfile.noble b/contrib/reprobuild/Dockerfile.noble
index e938a9ca08..4ae8ba321e 100644
--- a/contrib/reprobuild/Dockerfile.noble
+++ b/contrib/reprobuild/Dockerfile.noble
@@ -8,7 +8,8 @@ ENV PATH=/root/.pyenv/shims:/root/.pyenv/bin:/root/.cargo/bin:/root/.local/bin:$
 ENV PROTOC_VERSION=29.4

 RUN sed -i '/updates/d' /etc/apt/sources.list && \
-    sed -i '/security/d' /etc/apt/sources.list
+    sed -i '/security/d' /etc/apt/sources.list && \
+    sed -i 's/^deb \(.*\) noble main$/deb \1 noble main universe/' /etc/apt/sources.list

 RUN apt-get update \
        && apt-get install -y --no-install-recommends \
diff --git a/contrib/reprobuild/Dockerfile.resolute b/contrib/reprobuild/Dockerfile.resolute
index 945f38536c..2a103dd53a 100644
--- a/contrib/reprobuild/Dockerfile.resolute
+++ b/contrib/reprobuild/Dockerfile.resolute
@@ -8,7 +8,8 @@ ENV PATH=/root/.pyenv/shims:/root/.pyenv/bin:/root/.cargo/bin:/root/.local/bin:$
 ENV PROTOC_VERSION=29.4

 RUN sed -i '/updates/d' /etc/apt/sources.list && \
-    sed -i '/security/d' /etc/apt/sources.list
+    sed -i '/security/d' /etc/apt/sources.list && \
+    sed -i 's/^deb \(.*\) resolute main$/deb \1 resolute main universe/' /etc/apt/sources.list

 RUN apt-get update \
     && apt-get install -y --no-install-recommends \

…lute

Switch `Dockerfile.noble` and `Dockerfile.resolute` to noble / resolute to match the debootstrap-based minimal image approach.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants