Skip to content

askrene: fix crash loading node bias with description #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vincenzopalazzo wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −4
Open

askrene: fix crash loading node bias with description #9434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a744936
tests: restart the node which owns the layer in node bias test
vincenzopalazzo Aug 18, 2026
5fc57d9
askrene: fix crash loading node bias with description
vincenzopalazzo Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/askrene/layer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,10 +773,10 @@ static void load_node_bias(struct plugin *plugin,
&in_bias,
&out_bias,
&timestamp)) {
set_node_bias(layer, &node, take(description), in_bias,
set_node_bias(layer, &node, description, in_bias,
/* relative = */ false,
/* out dir = */ false, timestamp);
set_node_bias(layer, &node, take(description), out_bias,
set_node_bias(layer, &node, description, out_bias,
/* relative = */ false,
/* out dir = */ true, timestamp);
}
Expand Down
4 changes: 2 additions & 2 deletions tests/test_askrene.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ def test_node_bias_persistence(node_factory):
]
assert l1.rpc.askrene_listlayers("mylayer") == {"layers": [expect]}
# restarting the node we see the same data again
l2.restart()
l1.restart()
assert l1.rpc.askrene_listlayers("mylayer") == {"layers": [expect]}

r = l1.rpc.askrene_bias_node(
Expand All @@ -521,7 +521,7 @@ def test_node_bias_persistence(node_factory):
assert l1.rpc.askrene_listlayers("mylayer") == {"layers": [expect]}

# restarting the node we see the same data again
l2.restart()
l1.restart()
assert l1.rpc.askrene_listlayers("mylayer") == {"layers": [expect]}


Expand Down
Loading