Mobile model selector placement and alignment#783
Merged
Conversation
bdart
force-pushed
the
feature/mobile-model-selector-left-align
branch
from
159401c to
2952625
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the chat input UI to improve the placement and alignment of the
ModelSelectorcomponent, particularly for mobile and add-in layouts where controls are collapsed. The changes ensure that the model selector appears in a consistent and intuitive location and that its dropdown menu aligns correctly depending on its position.UI improvements for model selector placement and alignment:
showModelSelectorvariable to centralize logic for when theModelSelectorshould be rendered, ensuring it appears in the correct control group depending on layout and mode (ChatInput.tsx).ModelSelectorin the left control group (with left alignment) when the unified mobile menu is used, and in the right group otherwise (ChatInput.tsx). [1] [2]Component flexibility and alignment:
alignprop toModelSelector(defaulting to"right"), allowing its dropdown menu to align left or right based on context, and passed this prop through to the underlyingDropdownMenu(ModelSelector.tsx). [1] [2] [3]