### Information - #6607
Open
1wairesd wants to merge 3 commits into
Open
Conversation
PatternType.getByIdentifier() causes IncompatibleClassChangeError on 1.19.4 due to a mismatch between Methodref and InterfaceMethodref bytecode constants when compiled against a newer API. Introduce PatternTypeProvider with two implementations: - LegacyPatternTypeProvider: iterates PatternType.values() for 1.19.4 and older where PatternType is still an enum - ModernPatternTypeProvider: uses Registry.BANNER_PATTERN for 1.20.5+ Update MetaItemStack.addBannerMeta to resolve PatternType through the provider instead of calling the deprecated static method directly.
- Fix typo expCommandUsage4Description -> expCommandUsage3Description in messages.properties and messages_ru.properties - Tab-complete for /exp give|set|take no longer suggests player names without .others permission
JRoy
requested changes
Aug 11, 2026
JRoy
left a comment
JRoy
left a comment
Member
There was a problem hiding this comment.
lgtm, just need to move the other usage string up one.
Comment on lines
379
to
380
| expCommandUsage5=/<command> reset <playername> | ||
| expCommandUsage5Description=Resets the target player's xp to 0 |
| expCommandUsage2Description=Устанавливает опыт игрока на указанное количество | ||
| expCommandUsage3=/<command> show <игрок> | ||
| expCommandUsage4Description=Отображает количество опыта указанного игрока | ||
| expCommandUsage3Description=Отображает количество опыта указанного игрока |
Member
There was a problem hiding this comment.
changes to other locales won't be saved, when this PR is merged it will need to be updated on Crowdin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes.
Details
Proposed fix:
Fixed incorrect locale key numbering for the
/expcommand:expCommandUsage4Descriptionwas renamed toexpCommandUsage3Descriptionin bothmessages.propertiesandmessages_ru.properties. This caused aMissingResourceExceptionwhen players used/expwith insufficient arguments.Additionally, improved tab-completion for
/exp give|set|takeso that player names are only suggested when the user has the corresponding.otherspermission (e.g.essentials.exp.give.others). Without this permission, only amount values are suggested.Environments tested:
OS: Windows
Java version: 21
Demonstration:
Before:
/expcommand throwsMissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key expCommandUsage3DescriptionAfter: Help message displays correctly without errors.