feat: merge additive updater pull requests automatically - #6
Merged
Conversation
Same rule as the rest of the fleet: the agent's own pull request merges when every public symbol that existed still exists unchanged, and a human looks at anything else. With native-coherence folded into the gate rather than running beside it, so the merge actually depends on it. Without that, a regeneration against a newer header with the old binaries still in place reads as purely additive and would have merged past the one check that catches it.
Contributor
API gate: additiveEvery symbol that existed still exists, unchanged. Nothing that compiled before stops compiling.
Enum and constant values are part of the measured surface: a renumbering keeps compiling and sends the wrong number to the driver, so it counts as a removal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings Meshoptimizer.NET in line with the rest: auto-merge on an additive verdict.
The reason it was held back was that this repository rebuilds five native libraries when it bumps — and that reason was sound, but for a sharper cause than I gave. The
binding-updateragent runs the generator, not the native build, so an agent pull request regenerates C# against a newer header while leaving the old binaries in place. To the API gate that is purely additive: new symbols, none removed. Every one of those new symbols is missing from the libraries.Running as a separate workflow, the coherence check would have gone red and the merge would have proceeded anyway, because the merge job only looked at the API gate. Toolbox v1.12.0 folds it in, so
needscovers both.🤖 Generated with Claude Code