Skip to content

[Snyk] Security upgrade shell-quote from 1.8.3 to 1.8.4#90

Open
factory-service-snyk wants to merge 1 commit into
devfrom
snyk-fix-cb4fa31ea0b71cd5cc1bb92e882c5c85
Open

[Snyk] Security upgrade shell-quote from 1.8.3 to 1.8.4#90
factory-service-snyk wants to merge 1 commit into
devfrom
snyk-fix-cb4fa31ea0b71cd5cc1bb92e882c5c85

Conversation

@factory-service-snyk
Copy link
Copy Markdown

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • base-action/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
critical severity Arbitrary Command Injection
SNYK-JS-SHELLQUOTE-16799355
  735  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Arbitrary Command Injection

@factory-droid
Copy link
Copy Markdown
Contributor

factory-droid Bot commented May 27, 2026

Droid finished @factory-service-snyk's task —— View job


Security Review

Droid review complete.

The PR intent (upgrading shell-quote to address a critical vuln) isn’t fully realized yet because the base-action lockfiles still pin shell-quote@1.8.3; regenerate/update the lockfiles so installs actually pull 1.8.4.

Comment thread base-action/package.json
"dependencies": {
"@actions/core": "^1.10.1",
"shell-quote": "^1.8.3"
"shell-quote": "^1.8.4"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Dependency bump not realized in lockfiles

base-action/package.json bumps shell-quote to ^1.8.4, but both base-action/package-lock.json and base-action/bun.lock still reference/pin shell-quote@1.8.3 (including the resolved tarball). This can break reproducible installs (e.g. npm ci will fail if the lockfile is out of sync) and also means the intended vulnerability fix may not actually be applied in installs. Update/regenerate the lockfiles so they resolve to 1.8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants