chore(ci): pick up seeded changesets and the semantic-release fix#686
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| restore-keys: | | ||
| bench-npm-cache- | ||
| - uses: FerrLabs/Benchmarks@e1237b5e267fe331ea7dd78bbd313c3bf0ff2c72 # v5 + Fixtures v1.1.1 + sharding + cold-cache + startup/work split | ||
| - uses: FerrLabs/Benchmarks@4b589da3decd4d5ff9372b73410b6e516f2e0b02 # v5.5.0 + startup/work split + seeded changesets + semantic-release fix |
| pattern: bench-partial-* | ||
| path: partials/ | ||
| - uses: FerrLabs/Benchmarks@e1237b5e267fe331ea7dd78bbd313c3bf0ff2c72 # v5 + Fixtures v1.1.1 + sharding + cold-cache + startup/work split | ||
| - uses: FerrLabs/Benchmarks@4b589da3decd4d5ff9372b73410b6e516f2e0b02 # v5.5.0 + startup/work split + seeded changesets + semantic-release fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-pins the Benchmarks action from
e1237b5eto4b589da3(v5.5.0). Without this the two fixes below sit on Benchmarksmainand never reach a run — the action is SHA-pinned.FerrLabs/Benchmarks#178 — semantic-release runs again. It produced zero cells and was silently absent from the perf page.
git init --barepointsHEADatrefs/heads/masterwhile the fixtures are onmain, so semantic-release's earlygit fetch --tags origindied withfatal: couldn't find remote ref HEADand every fixture reportedSKIP: command failed. Expect it to appear in the chart on the next run, as the heaviest competitor by some margin (~3.7s onsinglelocally, ~1.6s of it work).FerrLabs/Benchmarks#176 — changesets gets real input. Six of seven fixtures gave it no
.changeset/*.md, sochangesets statusprinted "NO packages to be bumped" and we published the result as a benchmark. It now gets the changesets a maintainer would have written for the same history — 200 onmono-large, at the levels FerrFlow derives from the same commits.Worth being clear: #176 does not move the numbers. A/B on the real fixture put it at -35ms, i.e. noise — reading 200 changeset files is free, and changesets never reads the 10k commits by design. What changes is what the number means:
733 mswas changesets doing nothing; now it is changesets planning a real 200-package release.