Fix calling reload twice for package constants and improve hash calculation

[Noremos]

Fixes for the issue described in https://groups.google.com/g/firebird-devel/c/xIxhL_QAjEg : wierd error message when using a consatnt.

To reproduce:

set term ^;
CREATE PACKAGE TEST
AS
BEGIN
    CONSTANT C1 INTEGER = 10;
END^

CREATE PROCEDURE P1(I INT) RETURNS (PROCEDURE_OUTPUT INT)
AS
BEGIN
    PROCEDURE_OUTPUT = TEST.C1;
    SUSPEND;
END^

set term ;^
commit;

select TEST.C1 from rdb$database ;
select * from P1(0);
commit;

[AlexPeshkoff]

Fix is OK & and I approve it but one question. Why does dsc_address change with same value? Sorry but looks strange for constant.

[Noremos]

Fix is OK & and I approve it but one question. Why does dsc_address change with same value? Sorry but looks strange for constant.

This was a bug. First, the Package::reload method was called, creating a constant. Then, in the Package::checkReload method, m_callReload remained true, so the Package::reload method was called again. Constants were added and recreated. That's why I moved m_callReload = false to Package::reload in this PR.

[aafemt]

m_callReload remained true

Cannot dsc_address to be used instead of the flag to indicate that the constant is loaded? (With value NULL indicated by dsc_flags.)

[AlexPeshkoff]

On 6/1/26 18:47, Artyom Abakumov wrote: *Noremos* left a comment (FirebirdSQL/firebird#9045) <#9045 (comment)> Why does dsc_address change with same value? Sorry but looks strange for constant. This was a bug. First, the Package::reload method was called, creating a constant. Then, in the Package::checkReload method, m_callReload remained true, so the Package::reload method was called again. Constants were added and recreated. That's why I moved |m_callReload = false| to Package::reload in this PR.

Wonderful !!

[Noremos]

m_callReload remained true

Cannot dsc_address to be used instead of the flag to indicate that the constant is loaded? (With value NULL indicated by dsc_flags.)

The m_callReload is located inside the package class. The dsc_address is a field of the ConstantValue class, so it is not a correct optimization