Skip to content

Solve remaining sample app vulnerabilities#52

Merged
tsdamas merged 4 commits into
mainfrom
SDKS-5050-amend2
Jun 16, 2026
Merged

Solve remaining sample app vulnerabilities#52
tsdamas merged 4 commits into
mainfrom
SDKS-5050-amend2

Conversation

@tsdamas

@tsdamas tsdamas commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Documentation
    • Updated CI/build badge references in README to point to current workflows.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Two lines in README.md are updated to replace the build-packages.yml workflow reference with ci.yml in both the badge image URL and the badge link target, retaining the ?branch=main query parameter.

Changes

CI Badge Workflow Reference

Layer / File(s) Summary
README CI badge URL update
README.md
build-image badge URL and build-url link target are repointed from build-packages.yml to ci.yml on the main branch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 A badge once lost its way, oh dear,
Pointing to a workflow no longer here.
With two small lines I hopped and fixed,
ci.yml and main now neatly mixed.
The build shines green — hip hip, hooray! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title mentions 'sample app vulnerabilities' but the actual changes only update README CI/build badges to point to a new workflow. Update the title to accurately reflect the change, such as 'Point build badge to CI workflow on main' to match the actual file modifications.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch SDKS-5050-amend2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://ForgeRock.github.io/ping-react-native-sdk/docs-preview/pr-52/

Built to branch gh-pages at 2026-06-16 19:58 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@tsdamas tsdamas changed the title Point build badge to CI workflow on main Solve remaining sample app vulnerabilities Jun 16, 2026
@tsdamas tsdamas merged commit 90ef7c4 into main Jun 16, 2026
12 of 14 checks passed
@tsdamas tsdamas deleted the SDKS-5050-amend2 branch June 16, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants