Conversation
|
kstribrnAmzn
previously approved these changes
May 6, 2026
Member
|
The change looks sensible to me. Consider testing on a board like we've discussed before merging. |
rawalexe
force-pushed
the
timerFree
branch
3 times, most recently
from
57e6a06 to
f2db0b3
Compare
rawalexe
changed the title
| TimerHandle_t xInternalTimerHandle = NULL; | ||
| int32_t lIndex; | ||
|
|
||
| lIndex = ( int32_t ) xTimer; |
Member
There was a problem hiding this comment.
Is this okay? What if the xTimer value is 64 bit? How do we handle that?
Member
Member
|
Please investigate why the unit tests are failing |
When using MPU wrappers v2, xTimerDelete needs to be a real function rather than a macro so that the kernel object pool index can be freed after the timer is successfully deleted. Without this, deleting a timer leaks the kernel object pool entry. Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com>
rawalexe
force-pushed
the
timerFree
branch
3 times, most recently
from
62a857c to
77a465b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test Steps
Checklist:
Related Issue
Before the Fix:
After the FIx:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.