Unify Write tool to inline file_path + content#1016
Merged
Conversation
Remove the PlaintextFollowup two-step Write content generation path, settings UI, and round-executor follow-up logic so Write always submits file_path and content in one tool call aligned with Claude Code. Improve streaming Write UI path extraction and status copy when content arrives before file_path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
write_tool_modeconfig, round-executor follow-up AI calls, and related adapter/stream plumbing.file_path+content, updated guardrails, and cleaned agent prompts.file_pathfrom the params buffer when possible and showing clearer status copy when content streams before the path.Test plan
cargo check -p bitfun-core -p bitfun-ai-adapters -p bitfun-acpcargo test -p bitfun-core --lib file_write_toolcargo test -p bitfun-ai-adapters message_converterpnpm run type-check:webpnpm --dir src/web-ui run test:run src/shared/utils/partialJsonParser.test.ts src/flow_chat/services/flow-chat-manager/ToolEventModule.test.ts src/flow_chat/tool-cards/FileOperationToolCard.test.ts