test(website): make lineage-filter selection resilient to menu re-renders - #1358
Open
fhennig wants to merge 2 commits into
Open
test(website): make lineage-filter selection resilient to menu re-renders#1358fhennig wants to merge 2 commits into
fhennig wants to merge 2 commits into
Conversation
…ders (#1255) The variant-selection e2e tests (compareSideBySide, singleVariant) were flaky on Firefox/WebKit. The worst failure mode: fillLineageField typed into the lineage autocomplete then clicked the matching dropdown option, but the Downshift menu can be closed again by a concurrent re-render (each filter field fetches its options from LAPIS independently). The option then never appears and the click waits out the full 60s test timeout -- a larger timeout cannot help a closed menu. Re-open the menu and retry the option click together so a transient close cannot wedge the test. Also keep two mitigations for the slower "still loading" failure mode: bump @playwright/test 1.60->1.61 and set a global 15s expect timeout. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1255
Summary
The variant-selection e2e tests (compareSideBySide, singleVariant) were flaky on Firefox/WebKit. The worst failure mode: fillLineageField typed into the lineage autocomplete then clicked the matching dropdown option, but the Downshift menu can be closed again by a concurrent re-render (each filter field fetches its options from LAPIS independently). The option then never appears and the click waits out the full 60s test timeout -- a larger timeout cannot help a closed menu. Re-open the menu and retry the option click together so a transient close cannot wedge the test.
Also keep two mitigations for the slower "still loading" failure mode: bump @playwright/test 1.60->1.61 and set a global 15s expect timeout.