Add GitHub Actions CI for tests and linting - #41
Merged
Conversation
Adds a yarn lint script (eslint over src/) and a .github/workflows/ci.yml that runs lint and test jobs on push to main and on pull requests.
✅ Deploy Preview for imaginative-dieffenbachia-3400e7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlworkflow that runs on push tomainand on pull requests, with two parallel jobs:lintandtestlintscript topackage.json(eslint src --ext .js,.jsx,.ts,.tsx), reusing the existingeslintConfig(extends: react-app) — no new dependencies required sinceeslintis already pulled in transitively byreact-scriptsNODE_OPTIONS=--openssl-legacy-provider(matches the working Netlify build config, required forreact-scripts 3.4.4/webpack 4 on modern Node/OpenSSL) and cache yarn dependenciestestjob runs Jest non-interactively viayarn test --watchAll=falsewithCI=trueTest plan
yarn install --frozen-lockfilesucceeds locallyyarn lintpasses with no errors locallyCI=true yarn test --watchAll=falsepasses locally (11 test suites, 53 tests)lintandtestjobs pass on this PRGenerated by Claude Code