feat: [CHA-2956] connection pooling: getstream-ruby#62
Open
mogita wants to merge 15 commits into
Open
Conversation
…timeout, http_client to Configuration
The pool_size assertions read the handler's internal @Args ivar, whose layout changed between Faraday 2.8 (kwargs stored in @Args) and 2.9+ (kwargs in a separate @kwargs). CI floats Faraday versions (Gemfile.lock is gitignored for this gem), so @args.last was nil there and the two pool_size specs failed; the faraday_adapter escape-hatch spec only passed because its guard masked the same nil. Intercept the public Faraday::RackBuilder#adapter call instead — the same API the client uses — so the assertions hold regardless of how Faraday stores args internally. Production code unchanged.
mogita
changed the title
Remove Notion links and spec-section markers from changelog, client/config comments, and spec describe labels. Behavior unchanged.
When net_http_persistent cannot be configured, configure_adapter falls back to Faraday.default_adapter, which silently disables connection pooling. Previously the WARNING was emitted via logger&.warn, so it was completely silent when no logger was configured (the default for GetStreamRuby.manual). The construction INFO line also reported the requested faraday_adapter even when the build had silently fallen back to a different one. - Add Configuration#warn_pool_fallback, which emits the fallback WARNING via a default $stdout logger when none is configured, mirroring log_pool_config_to. A pooling-disable is never silent now. - Record the effective adapter on the configuration and have log_pool_config_to report it, so the INFO line reflects the adapter actually built rather than the requested-but-failed one. - Bump the gemspec faraday floor to ~> 2.5 to match the true floor imposed by faraday-net_http_persistent ~> 2.3 (needs faraday ~> 2.5). - Correct the Gemfile comment: connection_pool 3.x requires Ruby >= 3.2, not >= 3.4. The < 3.0 pin stays (CI runs Ruby 3.1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection pooling for getstream-ruby (CHA-2956).
Faraday.default_adapter(no pool) to:net_http_persistent(real per-process pool). Matches legacystream-chat-ruby.max_conns_per_host:(5),idle_timeout:(55s),connect_timeout:(10s),request_timeout:(30s).http_client:escape hatch: accepts a pre-builtFaraday::Connectionused as-is.request_timeout:override onClient#make_request.faraday_adapterconfig remains as an alternate escape hatch (pool knobs not applied when set).timeout:kwarg remains as a backwards-compat alias.New runtime deps
faraday-net_http_persistent ~> 2.3net-http-persistent ~> 4.0Versions match
stream-chat-ruby/stream-chat.gemspec.A Gemfile-only constraint
connection_pool < 3.0was added becauseconnection_pool 3.xrequires Ruby >= 3.4 while CI runs Ruby 3.1.net-http-persistentacceptsconnection_pool >= 2.2.4, < 4, so the pin is safe.Behavior change
Connection: keep-aliveheader no longer emitted on the default path (net_http_persistent keeps connections alive natively).Test plan
max_conns_per_host=5,idle_timeout=55,connect_timeout=10,request_timeout=30, adapter isNetHttpPersistenttimeout:kwarg still works as alias forrequest_timeout:http_client:escape hatch: user-supplied connection used verbatimfaraday_adapter:escape hatch: custom adapter used;pool_sizeNOT passedrequest_timeout:onmake_requestoverrides client defaultbundle exec rspec spec/(excluding integration) green: 248 examples, 0 failuresbundle exec rubocopclean: 36 files inspected, no offenses detectedbundle exec bundler-audit: only pre-existing advisories onaddressable/faraday/yard(same as master). Newnet-http-persistentandfaraday-net_http_persistenthave no advisories.bundle exec ruby -Ilib -rgetstream_ruby -e 'GetStreamRuby.manual(...)'prints expected INFO line andadapter=Faraday::Adapter::NetHttpPersistent.Refs
stream-chat-ruby/lib/stream-chat/client.rb:64-72