fix: skip hook when code assets are disabled - #17
Open
HeyChengdu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
code_assetsAPI documentsHookConfig.codeas available only whenbuildCodeAssetsis true. Flutter 3.44.6 can invoke this build hook duringflutter runwithout requesting Code Assets, so the unconditional access currently throws fromCodeConfig._fromJsonafter the macOS app has compiled and launched.This guard makes that unsupported hook invocation a successful no-op while preserving the existing Rust build path whenever Code Assets are requested.
Reproduction before the fix:
Verified after the fix:
flutter run -d macosreaches the Dart VM Service and restores hot reloadflutter analyzepasses in this package