Skip to content

fix shared storage access inside distros, bump to v1.0.3 - #7

Merged
GlobalTechInfo merged 1 commit into
mainfrom
v103-storage-fixes
Aug 2, 2026
Merged

fix shared storage access inside distros, bump to v1.0.3#7
GlobalTechInfo merged 1 commit into
mainfrom
v103-storage-fixes

Conversation

@GlobalTechInfo

@GlobalTechInfo GlobalTechInfo commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Fixes the missing /sdcard, /storage and /mnt binds in the proot terminal session (shared storage was invisible inside distros), restores the All files access request to the terminal screen, swaps the left/right arrow triangles in the default extra keys row, and bumps the version to v1.0.3 with changelog updates.

Summary by CodeRabbit

  • New Features

    • Storage access is now checked and requested from the terminal screen when needed.
    • Android 13+ notification permission is requested during terminal use.
    • Proot sessions can access shared storage locations.
    • Repeated storage-access requests now include explanatory notifications and are limited to avoid interruptions.
  • Bug Fixes

    • Corrected the default extra-key arrow ordering.
    • Updated the app version to 1.0.3.

- bind /sdcard, /storage and /mnt into the proot terminal session so
  /storage/emulated/0 is usable inside every distro
- request All files access from the terminal screen (was moved to the
  welcome screen where it could be skipped) and re-ask until granted
- swap the left/right arrow triangles in the default extra keys row
- bump version to 1.0.3 and update the changelog
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 49aeb77f-13b0-43f8-aa89-7c382968c6bc

📥 Commits

Reviewing files that changed from the base of the PR and between a53b64d and e1df70e.

📒 Files selected for processing (6)
  • CHANGELOG.md
  • app/build.gradle.kts
  • app/src/main/java/com/redtermapp/ui/SettingsActivity.kt
  • app/src/main/java/com/redtermapp/ui/TerminalActivity.kt
  • app/src/main/java/com/redtermapp/ui/WelcomeActivity.kt
  • app/src/main/java/com/redtermapp/util/StoragePermission.kt
💤 Files with no reviewable changes (1)
  • app/src/main/java/com/redtermapp/ui/WelcomeActivity.kt

📝 Walkthrough

Walkthrough

The app moves storage and notification permission handling from setup to TerminalActivity. It adds version-aware StoragePermission logic, shared storage mounts for proot sessions, updated extra-key ordering, and version 1.0.3 release metadata.

Changes

Terminal access and release updates

Layer / File(s) Summary
Centralized permission flow
app/src/main/java/com/redtermapp/util/StoragePermission.kt, app/src/main/java/com/redtermapp/ui/WelcomeActivity.kt, app/src/main/java/com/redtermapp/ui/TerminalActivity.kt
StoragePermission handles Android-version-specific access checks and requests. WelcomeActivity no longer requests permissions. TerminalActivity checks access during creation and resume, and requests notification permission on Android 13+.
Terminal environment and extra-key updates
app/src/main/java/com/redtermapp/ui/TerminalActivity.kt, app/src/main/java/com/redtermapp/ui/SettingsActivity.kt
Proot sessions bind /sdcard, /storage, and /mnt. Default and reset extra-key rows use left, down, right ordering.
Release metadata
app/build.gradle.kts, CHANGELOG.md
The app version changes to 1.0.3 with version code 2. The changelog records the release changes.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant WelcomeActivity
  participant TerminalActivity
  participant StoragePermission
  participant AndroidSettings
  WelcomeActivity->>TerminalActivity: finish setup without permission request
  TerminalActivity->>StoragePermission: check access during creation or resume
  StoragePermission-->>TerminalActivity: return accessibility status
  TerminalActivity->>StoragePermission: request access when unavailable
  StoragePermission->>AndroidSettings: open all-files access settings when required
Loading

Suggested reviewers: invalid-email-address

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main storage-access fix and the v1.0.3 version update.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v103-storage-fixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@GlobalTechInfo
GlobalTechInfo merged commit 3ebe1ac into main Aug 2, 2026
2 checks passed
@GlobalTechInfo
GlobalTechInfo deleted the v103-storage-fixes branch August 2, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant