feat: BigQuery Storage v1beta1 API migration guide - #3338
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a migration guide for transitioning the BigQuery Storage API from v1beta1 to v1 in C#. The feedback focuses on making the C# code examples more idiomatic and robust. Key suggestions include using the strongly-typed TableName class instead of a raw string path, clarifying how ReadRowsStream relates to IAsyncEnumerable, and using var to avoid type ambiguity with System.IO.Stream.
amanda-tarafa
left a comment
amanda-tarafa
left a comment
There was a problem hiding this comment.
Curious, why didn't you added actual samples that can be build and tested (like the ones we have for write) and then get the guide to reference those samples, instead of the code directly on the markdown. I can do a quick review but nothing will beat a compiler and some tests :).
|
Hi @amanda-tarafa ~ The v1 sample already exists (https://github.com/GoogleCloudPlatform/dotnet-docs-samples/blob/main/bigquery-storage/api/BigQueryStorage.Samples/Quickstart.cs#L35). This markdown is intended to highlight the difference between v1beta1 and v1, so customers can follow it to migrate to v1. WDYT? |
|
Yes, it's ultimate your decision, but I can't make sure that the code in the markdown is correct, and it may get obsolete over time, etc. I'll review and call out anything I see. |
benhxy
added
the
kokoro:force-run
amanda-tarafa
added
the
kokoro:run
kokoro-team
removed
kokoro:run
3 participants
Fixes b/505001153. BigQuery Storage team is planning to deprecate v1beta1 API. This PR adds a migration guide from v1beta1 to v1.