Skip to content

chore: bump sigs.k8s.io/controller-runtime/tools/setup-envtest#2181

Draft
tiffanny29631 wants to merge 2 commits into
GoogleContainerTools:mainfrom
tiffanny29631:fix-envtest-bump
Draft

chore: bump sigs.k8s.io/controller-runtime/tools/setup-envtest#2181
tiffanny29631 wants to merge 2 commits into
GoogleContainerTools:mainfrom
tiffanny29631:fix-envtest-bump

Conversation

@tiffanny29631
Copy link
Copy Markdown
Contributor

Bumps sigs.k8s.io/controller-runtime/tools/setup-envtest from 0.0.0-20250517180713-32e5e9e948a5 to 0.24.1.


updated-dependencies:

  • dependency-name: sigs.k8s.io/controller-runtime/tools/setup-envtest dependency-version: 0.24.1 dependency-type: direct:production update-type: version-update:semver-minor ...

Bumps [sigs.k8s.io/controller-runtime/tools/setup-envtest](https://github.com/kubernetes-sigs/controller-runtime) from 0.0.0-20250517180713-32e5e9e948a5 to 0.24.1.
- [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases)
- [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md)
- [Commits](https://github.com/kubernetes-sigs/controller-runtime/commits/v0.24.1)

---
updated-dependencies:
- dependency-name: sigs.k8s.io/controller-runtime/tools/setup-envtest
  dependency-version: 0.24.1
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@google-oss-prow
Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tiffanny29631. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project dependencies and vendored packages, including upgrading the Go version to 1.26.0 and updating various Kubernetes and protobuf libraries. Key changes in the vendored code include: enhancing metav1.FieldsV1 to support a string-backed representation using unique.Handle[string]; introducing new validation utilities such as Discriminated rules, path segment name validation, and additional limit checks; adding alpha support for sharded list and watch features via ShardSelector and ShardInfo; refactoring network helpers to support contextual logging with klog.Logger; and adding a fixed-size circular buffer TypedRingFixed in k8s.io/utils. All of the reviewer's comments were filtered out as they pertained to version numbers in configuration files, so we have no further feedback to provide.

@tiffanny29631
Copy link
Copy Markdown
Contributor Author

/test all

@google-oss-prow
Copy link
Copy Markdown

@tiffanny29631: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit-e2e-multi-repo-test-group1 b125054 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1
kpt-config-sync-presubmit-e2e-multi-repo-test-group3 b125054 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3
kpt-config-sync-presubmit-e2e-multi-repo-test-group2 b125054 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group2
kpt-config-sync-presubmit b125054 link true /test kpt-config-sync-presubmit
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant