fix(skill): share code extension source - #2398
Conversation
There was a problem hiding this comment.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify reviewed this change.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify review — findings
This PR replaces hardcoded inline sets of code file extensions (code_exts = {...}) across the graphify skill documentation files and generated skill outputs with an import of a shared CODE_EXTENSIONS constant from graphify.detect. The change spans the embedded Python snippets in numerous per-agent update.md reference files and the main skill markdown files (aider, devin, etc.), plus corresponding skillgen generator fragments, expected outputs, and tests. The surface area is broad but the edits are repetitive and mechanical, touching the code-file detection logic in each skill's incremental-update flow along with the skillgen tooling that produces these files.
Worth a look
- CODE_EXTENSIONS refactor may drop or alter recognized extensions per skill variant —
graphify/skill-aider.md:786· Escalate · medium- agreed by 2 of 2 members but NOT verified (no proof, no reproducing execution) — consensus is not a verdict; needs human review
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 530 functions depend on the 530 functions this change touches.
Health — grade A; 5 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):
audit_coverage()— 8 callers, 6 callees (high)render()— 12 callers, 4 callees (high)main()— 2 callers, 11 callees (medium)monolith_roundtrip()— 3 callers, 5 callees (medium)test_audit_catches_a_dropped_non_allowlisted_heading()— 0 callers, 6 callees (medium)
Verification — 530 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 530 function(s) in the blast radius were not formally verified this run
|
Follow-up on the automated review note: this is intentional and uses the same classification source as the runtime extractor. Every affected snippet runs through Validation included |
|
Follow-up: pushed |
There was a problem hiding this comment.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify reviewed this change.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify review — findings
This PR replaces inlined hardcoded code_exts sets across the graphify skill markdown files (skill-aider, skill-devin, and numerous per-agent references/update.md files) with an import of a shared CODE_EXTENSIONS constant from graphify.detect. Corresponding generator/fragment tooling and expected-output fixtures under tools/skillgen/ and their tests appear to be updated to match this change. The surface area is broad but the edits are largely repetitive, applying the same substitution pattern consistently across many files.
No blocking issues surfaced. 2 lower-confidence candidates did not survive cross-model review.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 530 functions depend on the 530 functions this change touches.
Health — grade A; 5 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):
audit_coverage()— 8 callers, 6 callees (high)render()— 12 callers, 4 callees (high)main()— 2 callers, 11 callees (medium)monolith_roundtrip()— 3 callers, 5 callees (medium)test_audit_catches_a_dropped_non_allowlisted_heading()— 0 callers, 6 callees (medium)
Verification — 530 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 530 function(s) in the blast radius were not formally verified this run
db34a83 to
c4bc225
Compare
There was a problem hiding this comment.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify reviewed this change.
Looks safe to merge — no coupling regressions and no blocking issues, checked against the code graph (not a self-assessment).
Graphify review — findings
This PR replaces the inline code_exts set literals (used to determine whether all changed files are code files during incremental updates) with an imported CODE_EXTENSIONS constant from graphify.detect, applied across the generated agent skill files (skill-aider.md, skill-devin.md) and the many per-agent references/update.md files. It also touches the skillgen tooling fragments, generator helpers, and expected/reference fixtures, along with numerous test files (rationale snapshots and skillgen assertions) that correspond to these generated outputs. The change is broad in surface area but appears to be a single mechanical refactor centralizing the code-extension list, propagated through the skillgen generation system and its expected fixtures/tests.
No blocking issues surfaced. 3 lower-confidence candidates did not survive cross-model review.
Analysis details — impact, health, verification
Impact & health
Graphify review
Impact — 530 functions depend on the 530 functions this change touches.
Health — grade A; 5 existing hotspot(s) in the area this change touches (pre-existing, not introduced here):
audit_coverage()— 8 callers, 6 callees (high)render()— 12 callers, 4 callees (high)main()— 2 callers, 11 callees (medium)monolith_roundtrip()— 3 callers, 5 callees (medium)test_audit_catches_a_dropped_non_allowlisted_heading()— 0 callers, 6 callees (medium)
Verification — 530 functions in the blast radius were not formally verified this run (proofs are advisory here).
Gate & verification
graphify gate
PASS — objectively clean (no health regressions, tests not run — proofs not run this pass (advisory)). Grounded, not self-assessed.
Advisory (not blocking):
- verification_scope: 530 function(s) in the blast radius were not formally verified this run
Summary
--updaterunbook importgraphify.detect.CODE_EXTENSIONSVerification
uv run --frozen pytest tests/test_skillgen.pyuv run --frozen python -m tools.skillgen --checkuv run --frozen python -m tools.skillgen --audit-coverageuv run --frozen python -m tools.skillgen --schema-singletonuv run --frozen python -m tools.skillgen --monolith-roundtripuv run --frozen python -m tools.skillgen --always-on-roundtripuv run --frozen ruff check tools/skillgen/gen.py tests/test_skillgen.pyFixes #2227