-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add vectorization support for raster images #4261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
seam0s-dev
wants to merge
16
commits into
GraphiteEditor:master
Choose a base branch
from
seam0s-dev:2332-raster-image-vectorization
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d32534b
Implement Vectorize node
seam0s-dev c9c84d7
Merge remote-tracking branch 'origin/master' into 2332-raster-image-v…
seam0s-dev 7e61767
Extend Vectorize node support to web
seam0s-dev 474236a
Move Vectorize node to "Vector" category
seam0s-dev 44af68c
Add vtracer config as node properties
seam0s-dev 5864226
Merge branch 'master' into 2332-raster-image-vectorization
seam0s-dev 67c9ad6
refactor: separate usvg parsing from ModifyInputsContext in SVG import
c-mateo cecaaed
Add fills and strokes to the List<Vector> output of vectorize node
c-mateo 1a5a8f3
Implement the VectorizeMode
c-mateo 5d5e0af
Refactor extract_all_paths into usvg_utils.rs
seam0s-dev f3e20c3
Fix error handling
seam0s-dev 29a146a
Merge branch 'master' into 2332-raster-image-vectorization
seam0s-dev 675776b
Merge remote-tracking branch 'origin/master' into 2332-raster-image-v…
seam0s-dev 82a5f72
Merge branch '2332-raster-image-vectorization' of https://github.com/…
seam0s-dev e9a688d
Migrate usvg_utils to use fill and stroke attributes
seam0s-dev b97cbf0
Merge remote-tracking branch 'origin/master' into 2332-raster-image-v…
seam0s-dev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
372 changes: 4 additions & 368 deletions
372
editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| pub mod convert_usvg_path; | ||
| pub mod render_ext; | ||
| mod renderer; | ||
| pub mod to_peniko; | ||
| pub mod usvg_utils; | ||
|
|
||
| pub use renderer::*; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1: Importing an SVG with a non-solid stroke, such as a gradient stroke, now crashes the document import because
extract_usvg_strokecan producestroke: Some(...)withstroke_paint: None, which this code unwraps. Guard the optional paint/list elements and skip unsupported stroke paints rather than panicking.(Based on your team's feedback about avoiding panicking Option handling.)
View Feedback
Prompt for AI agents