Skip to content

test(engine): de-flake bg pool Stop assertion in CI #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Patel230 merged 1 commit into from
Aug 2, 2026
Merged

test(engine): de-flake bg pool Stop assertion in CI #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion internal/engine/agent/background_agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,10 @@ func TestBackgroundAgentPool_StopCancelsInFlight(t *testing.T) {

pool.Stop()

// The registry only drains a task once its spawn fn returns, so poll
// until the cancellation is observed AND the task has exited.
deadline = time.Now().Add(2 * time.Second)
for !cancelled.Load() && time.Now().Before(deadline) {
for (!cancelled.Load() || pool.PendingCount() != 0) && time.Now().Before(deadline) {
time.Sleep(time.Millisecond)
}
if !cancelled.Load() {
Expand Down
Loading