SC-408 Node Connections helper functions#860
Open
nbeatty-gpa wants to merge 5 commits into
Open
Conversation
nbeatty-gpa
force-pushed
the
SC-408
branch
2 times, most recently
from
8f90fc2 to
5ca1041
Compare
prestoncraw
reviewed
May 29, 2026
Comment on lines
44
to
49
| const dbs = testDBs() | ||
| dbs.done((statuses: INamedStatusItem[]) => { | ||
| setExtDBStatus(statuses) | ||
| }).fail((d) => { | ||
| }).fail(() => { | ||
| setExtDBStatus([]) | ||
| }) |
Contributor
There was a problem hiding this comment.
With the component-level status state removed, loading now seems to be represented only by the initial Status: "Loading" values in NodeConnections. Are these API responses ever expected to return Status: "Loading", or should NodeConnections reset its own items to loading before each refetch? I’m mostly wondering about stale status display while a new request is in flight.
Contributor
Author
There was a problem hiding this comment.
That's a good point, the API never returns `Status: "Loading" so I'll look at resetting the items before a refetch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructures the helper functions which make network requests to check XDA and System Center connections, making them pure functions outside of the
NodeConnectionscomponent which return promises, allowing the network requests to be cleaned up.Also removes the unused
Statusstate.Jira Work Item(s)