Skip to content

fix(review): persist last_review + correct resolver enrollment key #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jongjunn wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix(review): persist last_review + correct resolver enrollment key #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions infrastructure/repositories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,14 +317,14 @@ def get_card(self, enrollment_id: str, lesson_id: str):

def save_card(self, enrollment_id: str, lesson_id: str, card: Card) -> None:
sql = """
INSERT INTO review_card (enrollment_id, lesson_id, stability, difficulty, due, state)
VALUES (%s, %s, %s, %s, %s, %s)
INSERT INTO review_card (enrollment_id, lesson_id, stability, difficulty, due, last_review, state)
VALUES (%s, %s, %s, %s, %s, %s, %s)
ON DUPLICATE KEY UPDATE
stability = VALUES(stability), difficulty = VALUES(difficulty),
due = VALUES(due), state = VALUES(state)
due = VALUES(due), last_review = VALUES(last_review), state = VALUES(state)
"""
with get_connection() as conn, conn.cursor() as cur:
cur.execute(sql, (enrollment_id, lesson_id, card.stability, card.difficulty, card.due, str(card.state)))
cur.execute(sql, (enrollment_id, lesson_id, card.stability, card.difficulty, card.due, card.last_review, str(card.state)))


class MySQLPendingReviewRepository:
Expand Down Expand Up @@ -430,7 +430,7 @@ class MySQLEnrollmentQuizResolver:
lesson↔quiz는 N:N(lesson_quiz_map)이라 '이 학생이 그 레슨 퀴즈 중 가장 최근 제출한 quiz'를 택함."""

def get_member_id(self, enrollment_id: str):
sql = "SELECT member_id FROM enrollment WHERE id = %s"
sql = "SELECT member_id FROM enrollment WHERE enrollment_id = %s"
with get_connection() as conn, conn.cursor() as cur:
cur.execute(sql, (enrollment_id,))
row = cur.fetchone()
Expand Down