Feature: step content information#3005
Merged
Merged
Conversation
StylianosGakis
approved these changes
Jun 24, 2026
Comment on lines
+945
to
+956
| if (stepItem.stepContent.isSkippable) { | ||
| HedvigButton( | ||
| modifier = modifier.fillMaxWidth(), | ||
| text = stringResource(Res.string.claims_skip_button), | ||
| onClick = dropUnlessResumed { | ||
| onEvent(Skip(stepItem.id)) | ||
| }, | ||
| enabled = true, | ||
| buttonStyle = ButtonDefaults.ButtonStyle.Secondary | ||
| ) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Since we have override val isSkippable: Boolean = false always there I suppose this is never hit?
Is this supposed to be wired up later or just not applicable for this step type?
Contributor
Author
There was a problem hiding this comment.
never hit, removed
# Conflicts: # app/design-system/design-system-hedvig/src/commonMain/kotlin/com/hedvig/android/design/system/hedvig/StartClaimBottomSheet.kt
- Restore dropUnlessResumed guard on navigateToClaimChat in HomeEntries - Parse raw value (it.value) instead of display text (it.text) for DATE fields - Drop unmapped createdAt field from ClaimIntentFragment - Fix 5-space indent to 4-space in ResumeClaimQuery.graphql - Assert draftClaim is null when ENABLE_CLAIM_INTENT_RESUME flag is off
- Expired notice: single Close that removes the draft (matches Figma), replacing the two-button Start-new-claim/Cancel flow - Draft card: reuse the existing Submitted progress segment instead of a custom Started label - Draft card: red destructive label on Delete via a new HedvigSecondaryRedTextButton - Draft dialog: drop the Cancel button (Continue draft / Start new claim only)
Switch DraftClaimDialog to the design-system two-button dialog (like the Delete-draft alert) so the buttons sit side by side when they fit and stack otherwise. Add an opt-in confirmButtonRedText flag to DialogStyle.Buttons so the destructive 'Start new claim' confirm renders as a secondary fill with a red label, matching the Ready-for-dev design, wired through both the horizontal and vertical button layouts. Also relocate the expired-dialog comment out of the call arguments so ktlint keeps it.
# Conflicts: # app/feature/feature-home/src/main/kotlin/com/hedvig/android/feature/home/home/data/GetHomeDataUseCase.kt
The develop merge added two new tests (a cross-sell addon presenter test and a recommended-addon mapping test) that predate the resume-claim parameters, so their HomePresenter/HomeData/HomeQuery construction sites needed the deleteClaimIntentDraftUseCase, draftClaim, and resumeClaimEnabled arguments. Also reindent the flatMapLatest combine lambda in GetHomeDataUseCase.
# Conflicts: # app/apollo/apollo-octopus-public/src/commonMain/graphql/com/hedvig/android/apollo/octopus/schema.graphqls # app/feature/feature-claim-chat/src/commonMain/kotlin/com/hedvig/feature/claim/chat/ClaimChatViewModel.kt # app/feature/feature-claim-chat/src/commonMain/kotlin/com/hedvig/feature/claim/chat/ui/ClaimChatDestination.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New stepContent - Information with 2 levels of severity.
link to slack