PairedData bug fix and CSV functionality#116
Merged
ultjeremy merged 6 commits intoJul 15, 2026
Merged
Conversation
ultjeremy
commented
Jul 14, 2026
ultjeremy
commented
Collaborator
- Added to_csv and read_csv functionality for PairedData type
- Fixed bug in curve_count(), which returned number of ordinates rather than number of curves
- Added extensive testing suite for CSV functionality
ktarbet
reviewed
Jul 14, 2026
| value_str: str = row[2].strip() | ||
| try: | ||
| value: float = float(value_str) if value_str else 0.0 | ||
| value: float = float(value_str) if value_str else DEFAULT_MISSING_VALUE |
Contributor
There was a problem hiding this comment.
If we have a valid date-time, but not a valid value, let's use DEFAULT_MISSING_VALUE instead of skipping the row (to preserve regular intervals).
And for DEFAULT_MISSING_VALUE let's use either null or the DSS definition of Missing: -3.402823466e+38 . check if there is an example with time-series to keep consistency.
ktarbet
approved these changes
Jul 15, 2026
ultjeremy
marked this pull request as ready for review
July 15, 2026 20:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.