Add a comments sidebar & associate comments to specific objects - #4923
Open
wes-otf wants to merge 11 commits into
Open
Add a comments sidebar & associate comments to specific objects#4923wes-otf wants to merge 11 commits into
wes-otf wants to merge 11 commits into
Conversation
frjo
reviewed
Aug 11, 2026
frjo
reviewed
Aug 11, 2026
| {% if activities.count > 1 or activities.count == 1 and not preview_activity %} | ||
| <details class="collapse collapse-arrow group" id="statusDetail" {% if open %}open{% endif %}> | ||
| <summary class="collapse-title"> | ||
| <h2 class="card-title">{% blocktrans with activity_count=activities.count %}Status & Activity <span class="font-normal text-base-content/70">({{ activity_count }})</span>{% endblocktrans %}</h2> |
Member
There was a problem hiding this comment.
If possible, avoid tags in translated strings.
Contributor
Author
There was a problem hiding this comment.
what do you think makes the most sense for this? for RTL languages I figured the ability to put the count on the left would be ideal, but can also include the variable in the translation & just remove the formatting, just thought it was slick.
frjo
reviewed
Aug 11, 2026
frjo
reviewed
Aug 11, 2026
frjo
reviewed
Aug 11, 2026
frjo
reviewed
Aug 11, 2026
…conditional field inclusion with `CommentForm`, small timeline formatting fixes
wes-otf
commented
Aug 13, 2026
| {% if not object.is_archive or object.projects.exists %} | ||
| <h2 class="sr-only">{% trans "Add communication" %}</h2> | ||
| <div class="pb-6 mb-4 w-full border-b border-base-300"> | ||
| <div class="pb-6 w-full border-b border-base-300"> |
Contributor
Author
There was a problem hiding this comment.
this was causing a gap between the start of the border & the timeline line which is why I removed it here
wes-otf
marked this pull request as ready for review
August 13, 2026 15:45
wes-otf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4871. Adds the ability to comment on objects like Project Forms, SOWs, Reports & Invoices via a "mini" comment form in the detail view sidebar for said objects.
This PR also covers a few related yet adjacent things:
max-w-[60rem]→max-w-240)TODO:
Make status updates to PF/SOW reactive like they are for InvoicesAssociate status updates (ie. approvals) to the ProjectFormPointer instead of the project so they show in the Status & Activity sectionTest Steps
Confirm that...