root - chore: upgrade code quality dependencies + adopt pnpm 11 / Node 22-26 CI#132
Merged
Merged
Conversation
- @biomejs/biome 2.4.11 -> 2.4.16 - @vitest/coverage-v8 4.1.4 -> 4.1.8 - vitest 4.1.4 -> 4.1.8 https://claude.ai/code/session_01N45mbsSvk2ddx9LWVqKwf2
…/26 CI - Pin pnpm 11 via packageManager field for corepack - Migrate pnpm-workspace build approval to pnpm 11 allowBuilds config (onlyBuiltDependencies is no longer honored, which broke CI installs) - Switch CI workflows from 'npm install pnpm -g' to pnpm/action-setup@v4 with setup-node pnpm cache - Consolidate test matrix to Node 22, 24, 26 (drop Node 20) https://claude.ai/code/session_01N45mbsSvk2ddx9LWVqKwf2
jaredwray
changed the title
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Bump pnpm/action-setup from the deprecated v4 (Node 20 runtime) to v6.0.8, pinned by full commit SHA to satisfy the supply-chain pinning policy. https://claude.ai/code/session_01N45mbsSvk2ddx9LWVqKwf2
…eable 2.3.5) @cacheable/net 2.0.8 routes requests through the runtime's native fetch instead of the bundled undici, and pulls in cacheable 2.3.5. Upgrading to pick up that change for the QR-code POST path. - @cacheable/net 2.0.7 -> 2.0.8 - cacheable 2.3.4 -> 2.3.5 https://claude.ai/code/session_01N45mbsSvk2ddx9LWVqKwf2
The Hyphen API now rejects the createQrCode custom-options payload with HTTP 400 (it was accepted through at least 2026-04-13); tracked in #133. Skip the live integration test and add a stubbed unit test that still exercises the custom-options request-body branches so coverage stays at 100%. https://claude.ai/code/session_01N45mbsSvk2ddx9LWVqKwf2
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 477 477
Branches 99 99
=========================================
Hits 477 477 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade the code quality tooling group and modernize the toolchain to pnpm 11 + corepack, with a refreshed CI matrix.
Versions
@biomejs/biome2.4.11→2.4.16@vitest/coverage-v84.1.4→4.1.8vitest4.1.4→4.1.8Toolchain / CI
packageManagerfield (corepack).pnpm-workspace.yamlbuild approval from the legacyonlyBuiltDependencieslist to pnpm 11'sallowBuildsconfig. pnpm 11 no longer honorsonlyBuiltDependencies, which is whypnpm installwas hard-failing withERR_PNPM_IGNORED_BUILDS: esbuildin CI.npm install pnpm -gtopnpm/action-setup, pinned to a verified commit SHA (0e279bb… # v6.0.8) per the supply-chain policy, withactions/setup-nodepnpm caching.Tests
pnpm install --frozen-lockfileruns build scripts and exits 0pnpm buildpassespnpm lintpassesvitestpasses 230/231 across Node 22/24/26Known unrelated failure (not caused by this PR)
One pre-existing live-API integration test fails deterministically:
test/link.test.ts > should create a QR code with custom options→ HTTP 400. This PR changes nosrc//test/code; the basic QR tests pass. Tracked separately in #133.https://claude.ai/code/session_01N45mbsSvk2ddx9LWVqKwf2