@hyphen/react-sdk - fix: upgrade TypeScript tooling#39
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request upgrades TypeScript from version 6.0.2 to 6.0.3 and updates the lock file. Feedback suggests also downgrading @types/node to version 24.x to align with the project's Node 24 CI environment and avoid potential runtime type mismatches.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 19
Branches 1 1
=========================================
Hits 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- typescript 6.0.2 → 6.0.3 Note: @types/node skipped — currently at ^25.6.0 which already exceeds the project's configured Node 24 (per CI). It should be downgraded to @types/node@24.x to match the project's Node version. https://claude.ai/code/session_01UpDT9f536oc7bqEinP37BG
jaredwray
force-pushed
the
claude/upgrade-typescript
branch
from
90d5ed7 to
b4e89cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescript6.0.2 → 6.0.3 (patch release)Notes
@types/nodewas intentionally skipped. It is currently pinned at^25.6.0, but the project's CI configures Node 24 — meaning@types/nodeis already at a major version higher than the configured Node. It should be downgraded to@types/node@24.xto match, rather than upgraded further.Test plan
pnpm lintpassespnpm testpasses (4 test files, 15 tests, 100% coverage)https://claude.ai/code/session_01UpDT9f536oc7bqEinP37BG
Generated by Claude Code