Exclude GAM paths from Prebid refresh auctions - #965
Open
ChristianPavilonis wants to merge 1 commit into
Open
Conversation
ChristianPavilonis
marked this pull request as ready for review
August 3, 2026 15:55
ChristianPavilonis
requested review from
aram356 and
prk-Jr
and removed request for
aram356
August 3, 2026 15:55
ChristianPavilonis
force-pushed
the
prebid-refresh-path-opt-out-spec
branch
from
August 3, 2026 16:00
f431f73 to
f3dc6ba
Compare
prk-Jr
requested changes
Aug 3, 2026
prk-Jr
left a comment
Collaborator
There was a problem hiding this comment.
Summary
The refresh-path exclusion behavior, validation, injection, and test coverage look sound. One blocking CI failure must be resolved before merge.
Blocking
🔧 wrench
- TypeScript lint failure: The new refresh-exclusion tests introduce 12 explicit
anycasts rejected by@typescript-eslint/no-explicit-anyincrates/trusted-server-js/lib/test/integrations/prebid/index.test.ts(beginning at line 1534 and continuing through line 1695). Replace them with the existing typed test-window/PBJS helpers or narrow test interfaces so the blocking lint job passes.
CI Status
- TypeScript lint/format job: FAIL — 12
no-explicit-anyerrors - Rust tests and adapter checks: PASS
- Browser and integration tests: PASS
- Vitest: PASS
- Rust and docs formatting: PASS
- CodeQL and analysis: PASS
ChristianPavilonis
added a commit
that referenced
this pull request
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
crates/trusted-server-core/src/integrations/prebid.rscrates/trusted-server-js/lib/src/integrations/prebid/index.tscrates/trusted-server-js/lib/test/integrations/prebid/index.test.tsdocs/guide/integrations/prebid.mdtrusted-server.example.tomldocs/superpowers/{specs,plans}/2026-07-24-prebid-refresh-gam-path-opt-out*Closes
Closes #964
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute serve/tmp/trusted-server-prebid-refresh-path-opt-out.Checklist
unwrap()in production code — useexpect("should ...")println!was added