fix(ibm-validate-schema-example): support circular references in schemas#823
Open
diatrcz wants to merge 2 commits into
Open
fix(ibm-validate-schema-example): support circular references in schemas#823diatrcz wants to merge 2 commits into
diatrcz wants to merge 2 commits into
Conversation
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
Signed-off-by: Lídia Tarcza <100163235+diatrcz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Around the beginning of the year we fixed a bug where the
ibm-validate-schema-examplerule made the validator crash if circular referencies were present in the API definition.While looking through the old
2.xbranch, I found a commit that fixes this issue without a workaround. This PR contains those fixes from the commit while reverting the original workaround way.PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements: