Fix drag-and-drop regression in playlist#659
Open
for13to1 wants to merge 1 commit into
Open
Conversation
Commit 44d1d86 refactored dragMoveEvent by inverting the dropTarget null check, but introduced two regressions: 1. External file drops (e.g. from file manager) are rejected because the event is ignored when dropTarget is null (empty area) or when selectedItems() is empty (over an item). 2. Internal reordering is broken when dragging between items because the drop on the gap between items returns a null dropTarget, and the event is now explicitly ignored instead of being delegated to QTreeWidget::dragMoveEvent. Fix by handling external file drops (hasUrls) early before any playlist-internal validation, and delegating null-dropTarget internal drags to the base class.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 44d1d86 refactored dragMoveEvent by inverting the dropTarget null check, but introduced two regressions:
External file drops (e.g. from file manager) are rejected because the event is ignored when dropTarget is null (empty area) or when selectedItems() is empty (over an item).
Internal reordering is broken when dragging between items because the drop on the gap between items returns a null dropTarget, and the event is now explicitly ignored instead of being delegated to QTreeWidget::dragMoveEvent.
Fix by handling external file drops (hasUrls) early before any playlist-internal validation, and delegating null-dropTarget internal drags to the base class.