Adding manifest for commenting annotation camera view activation via …#80
Adding manifest for commenting annotation camera view activation via …#80gjcope wants to merge 1 commit into
Conversation
|
@glenrobson is this validation fail a validator issue? It's flagging a duplicate id, but I think in this case it is necessary unless I'm misunderstanding the spec (totally possible!) |
|
For what it's worth, I've also seen validator errors on trying to implement the scope shorthand elsewhere. |
|
I think the manifest is valid; the requirement that ids be strictly unique is too stringent, because it doesn't allow for referencing an annotation from another annotation, as would be required for scope and lookAt properties. A useful validator related to unique id', in that it would catch true errors, would be to check that is two JSON objects have the same id, they must also have the same type. |
|
The presentation-validator code already has the ability to ignore some properties when checking for unique ids. This list already includes "lookAt", "source", and others. I have submitted a PR IIIF/presentation-validator#216 to add "scope" to this list. All the manifests in the gjcope/dev-activating-scope branch pass this version of the validator code. |
|
Thanks @vincentmarchetti ! |
…scope