[FIX] LTI: Derive status lists from outcomes#11667
Open
Saaweel wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This follow-up adjusts the LTI outcome learning progress status list methods so they no longer derive their user lists from
ut_lp_marks._getInProgress(),_getCompleted()and_getFailed()now collect users from the underlying LTI outcome data:lti_consumer_resultslti_consumer_grades, if availableThe users are then classified through the existing
determineStatus()logic.This keeps parent object / LP collection aggregation working while avoiding a circular dependency during
ilLPStatusWrapper::_refreshStatus(), where these methods are used to recalculate and persistut_lp_marks.The existing Basic Outcomes status semantics are preserved.
Related
Original PR: #11641
Follow-up to the review comment on commit
3beedccc0067c9fbbb9531c0e21845a099a1dc11.Mantis: https://mantis.ilias.de/view.php?id=41919