Skip to content

Add Guestbook Response Sorting by fields - #12568

Open
stevenwinship wants to merge 5 commits into
developfrom
12524-sort-guestbook-responses
Open

Add Guestbook Response Sorting by fields#12568
stevenwinship wants to merge 5 commits into
developfrom
12524-sort-guestbook-responses

Conversation

@stevenwinship

Copy link
Copy Markdown
Contributor

What this PR does / why we need it: Modern UI needs to sort the output of the get guestbook response api

Which issue(s) this PR closes:#12524

Special notes for your reviewer:

Suggestions on how to test this: create multiple Datasets using a Guestbook and populate responses. Using the API retrieve the responses with various sort/order query parameters. Test with large numbers for performance hits due to the added db table joins.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Jul 29, 2026
@github-actions github-actions Bot added Feature: Guestbook GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA These changes are required for the Dataverse SPA Type: Feature a feature request labels Jul 29, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Jul 29, 2026
@stevenwinship stevenwinship added this to the 6.12 milestone Jul 29, 2026
@coveralls

coveralls commented Jul 29, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 24.97%. remained the same — 12524-sort-guestbook-responses into develop

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Test Results

403 tests  ±0   388 ✅ ±0   33m 37s ⏱️ +11s
 55 suites ±0    15 💤 ±0 
 55 files   ±0     0 ❌ ±0 

Results for commit fccdd1c. ± Comparison against base commit 0a49c4c.

♻️ This comment has been updated with latest results.

@cmbz cmbz added FY27 Sprint 2 FY27 Sprint 2 (2026-07-15 - 2026-07-29) FY27 Sprint 3 FY27 Sprint 3 (2026-07-29 - 2026-08-12) labels Jul 29, 2026
@github-actions

This comment has been minimized.

@stevenwinship
stevenwinship force-pushed the 12524-sort-guestbook-responses branch from 6403b3f to ec51106 Compare July 31, 2026 21:13
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@sonarqubecloud

sonarqubecloud Bot commented Aug 3, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
15.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12524-sort-guestbook-responses
ghcr.io/gdcc/configbaker:12524-sort-guestbook-responses

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Order order;
String orderField = (sortField == null) ? "" : sortField.toLowerCase();
switch(orderField) {
case "dataset":

@qqmyers qqmyers Aug 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK _ I see what you're concerned about - not the CriteriaBuilder per se, but the fact that it's a really complex join to sort by dataset name (for example). It sounds like denormalization or a materialized view might be required to be efficient (according to AI). I'm not sure I know enough to decide what the tradeoffs might be there, so maybe some tech hr discussion needed. Alternately - if this looks like more work than expected, perhaps going back to the UI side and asking if sorting on these is really useful versus filtering or allowing guestbook response viewing on a dataset of file page (so one could select a given dataset name and filter by it, with the query underneath just being adding a where dataset_id=X clause (or file, or user, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Guestbook FY27 Sprint 2 FY27 Sprint 2 (2026-07-15 - 2026-07-29) FY27 Sprint 3 FY27 Sprint 3 (2026-07-29 - 2026-08-12) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA These changes are required for the Dataverse SPA Type: Feature a feature request

Projects

Status: In Progress 💻

Development

Successfully merging this pull request may close these issues.

Update guestbook responses to sort by guestbook response fields

4 participants