IQSS/12548: Add privateurl gb check in downloads - #12569
Draft
qqmyers wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: This is a minimal fix for the issue of a Private URL user not being able to download files from the JSF UI when a guestbook is in use. I believe it also solves the issue of downloads/previewing from previewers.
Which issue(s) this PR closes:
Special notes for your reviewer: This PR follows the same pattern as for authenticated users added in #12110 - if the API call comes in without authentication, make a special check for authentication via the session and verify that user has permission to download from the draft and disable the guestbook requirement if they do. An alternative approach would be to sign the download URL that the JSF will redirect to, but if that approach is taken, it should probably be done for both Private and Authenticated users.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: