Skip to content

Add API for supporting external vocabularies in SPA - #12577

Draft
ekraffmiller wants to merge 1 commit into
developfrom
external-vocabulary-api
Draft

Add API for supporting external vocabularies in SPA#12577
ekraffmiller wants to merge 1 commit into
developfrom
external-vocabulary-api

Conversation

@ekraffmiller

Copy link
Copy Markdown
Contributor

This is a draft PR to serve as a proof of concept for supporting external vocabularies in the frontend. Not ready for review yet!

What this PR does / why we need it:

Which issue(s) this PR closes:

  • Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

Add API for supporting external vocabularies in Modern frontend

private JsonValue getJson(String requestUri, JsonObject config) throws ExternalVocabularyException {
try (Client client = ClientBuilder.newClient()) {
Invocation.Builder request = client.target(requestUri).request();
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
22.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:external-vocabulary-api
ghcr.io/gdcc/configbaker:external-vocabulary-api

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@github-actions

Copy link
Copy Markdown

Test Results

403 tests  ±0   387 ✅  - 1   38m 30s ⏱️ + 3m 59s
 55 suites ±0    15 💤 ±0 
 55 files   ±0     1 ❌ +1 

For more details on these failures, see this check.

Results for commit b9124be. ± Comparison against base commit d88961a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants