Add OPI for Lakeshore625#1848
Open
Spencer-Cheverton wants to merge 1 commit into
Open
Conversation
Tom-Willemsen
requested changes
Jun 5, 2026
Tom-Willemsen
left a comment
Tom-Willemsen
left a comment
Member
There was a problem hiding this comment.
The OPI will needs adding to opi_info.xml in order to be usable in the IBEX GUI.
| </foreground_color> | ||
| <grid_space>6</grid_space> | ||
| <height>600</height> | ||
| <macros> | ||
| <include_parent_macros>true</include_parent_macros> | ||
| <PV_ROOT>$(P)$(NANODAC)</PV_ROOT> | ||
| <PV_ROOT>$(P)$(KEPCO):</PV_ROOT> |
Member
There was a problem hiding this comment.
This looks to refer to a KEPCO macro, which doesn't look right for a Lakeshore 625.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of work
Created an OPI for Lakeshore625.
Ticket
ISISComputingGroup/IBEX#8782
Acceptance criteria
Code Review
check_opi_format.pyscript in C:\Instrument\Dev\ibex_gui\base\uk.ac.stfc.isis.ibex.opis pass?Final Steps