Add Legend watch face#2450
Conversation
|
Build size and comparison to main:
|
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Looks great overall :)
A few comments, but nothing big
I am curioous, how much did you use LLMs (if at all) during development of this watchface?
88014ff to
db9d562
Compare
|
@mark9064 Thanks for the fast review! I have fixed the issues you highlighted and rebased the PR. Can you please review again? |
There was a problem hiding this comment.
I think the code itself is all good. Could you take a look at all the comments though, some of them seem a bit overblown - I would say that most of the description isn't needed because if I want detail I will read the code. Visual markers for sections are probably still useful though. I've highlighted a few here
I find LLMs quite like to do this with comments :)
Also, have you tested this with AOD? Does it still look OK? (It's fine if some UI elements disappear that aren't important, but it needs to stay usable)
| // Notification indicator. Empty string when nothing is unread, | ||
| // so the label costs no pixels and no redraws in the common case. |
There was a problem hiding this comment.
I don't think the description is adding much value
There was a problem hiding this comment.
Can we keep it with a shorted text (to help distinguish between this and the any notification indicator)?
| // Services icons. Empty string when nothing is active, | ||
| // so the label costs no pixels and no redraws in the common case. |
There was a problem hiding this comment.
I would like to keep this with a shortened and improved text. Is the new text OK?
| lv_obj_align(bleIcon, batteryValue, LV_ALIGN_OUT_LEFT_MID, -10, 0); | ||
| lv_obj_set_auto_realign(bleIcon, true); | ||
|
|
||
| // Upper divider - indicator of silence |
There was a problem hiding this comment.
"indicator of silence" could be phrased better: maybe notification mode?
There was a problem hiding this comment.
Improved. Is the new text OK?
| if (stepCount.IsUpdated()) { | ||
| const uint32_t steps = stepCount.Get(); | ||
| if (steps >= 1000) { | ||
| // "6.4k" style: compact, fixed maximum width |
There was a problem hiding this comment.
This comment just describes the code. But also isn't it incorrect? If I do >10k steps, it gets one digit longer, and same is true for 100K (though I've only ever done about 40!)
There was a problem hiding this comment.
Maximum length indeed is not fixed. And also this shortening does not save any space (hundreds are still shown, dozens and ones are replaces with "." and "k"). Thanks for pointing to this! I have removed the non-working "shortening".
I think 100k steps will be around 80 km, so I think we can assume usually 5 digits max (that will be as wide as the "steps" label).
An elegant and very practical digital watch face. Uses only fonts already in InfiniTime and no external resources. Has the standard functionality: * shows time, date (without year) and day of week * supports 24 and 12 hour time formats * BLE, new notification and alarm clock icons * battery percentage (green when charging) * steps and heart rate * temperature and weather icon Additionally: * visual indication (amber dot) for any notification(s) * visual indication (red or blue line) when notifications are muted * battery percentage turns red when 20% or less * stopwatch and timer icons (when active) * colorful sun, snow and thunderstorm weather icons * generally uses brighter colors for more urgent things
|
@mark9064 Thanks! |
2 participants
An elegant and very practical digital watch face.
Uses only fonts already in InfiniTime and no external resources. Has the standard functionality:
Additionally: