Support smart scheduling across daemons#13
Open
kerthcet wants to merge 4 commits into
Open
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates daemon listing/filtering to support multi-label (AND) matching end-to-end across the Rust registry and the Python API, and refreshes docs/tests/examples to use the “daemon/server” terminology and the new filtering interface.
Changes:
- Replace single
(label_key, label_value)filtering with an optionallabels: HashMapfilter (AND semantics) in the Rust registry and the PyO3 API. - Update Python wrapper/tests to call
list_daemons(labels={...}), including new multi-label integration/E2E assertions. - Improve E2E session output collection and add a new programmatic session example.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| server/src/registry.rs | Changes daemon listing filter to accept a labels map and apply AND logic. |
| server/src/lib.rs | Updates PyO3 list_daemons signature to accept an optional labels dict. |
| README.md | Updates docs terminology and quick-start snippets (server/daemon). |
| python/tests/test_unit.py | Updates unit tests to call list_daemons(labels=...). |
| python/tests/test_integration.py | Updates integration tests for label filtering, adds multi-label AND test. |
| python/tests/test_e2e.py | Updates E2E label filtering calls; adds a same-daemon concurrency test; improves session multiline reading. |
| python/sandd/init.py | Updates Python wrapper list_daemons signature/docs and call into Rust binding. |
| examples/programmatic_session.py | Adds a new example showing programmatic session usage patterns. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+129
to
+133
| # Start slow command (3s) and fast command concurrently | ||
| with concurrent.futures.ThreadPoolExecutor(max_workers=3) as executor: | ||
| slow_future = executor.submit(run_sleep, 3) | ||
| fast_future = executor.submit(run_fast) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?