Skip to content

Support smart scheduling across daemons#13

Open
kerthcet wants to merge 4 commits into
InftyAI:mainfrom
kerthcet:feat/support-orche
Open

Support smart scheduling across daemons#13
kerthcet wants to merge 4 commits into
InftyAI:mainfrom
kerthcet:feat/support-orche

Conversation

@kerthcet
Copy link
Copy Markdown
Member

@kerthcet kerthcet commented Jun 4, 2026

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?


kerthcet added 4 commits June 3, 2026 12:08
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Copilot AI review requested due to automatic review settings June 4, 2026 15:21
@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates daemon listing/filtering to support multi-label (AND) matching end-to-end across the Rust registry and the Python API, and refreshes docs/tests/examples to use the “daemon/server” terminology and the new filtering interface.

Changes:

  • Replace single (label_key, label_value) filtering with an optional labels: HashMap filter (AND semantics) in the Rust registry and the PyO3 API.
  • Update Python wrapper/tests to call list_daemons(labels={...}), including new multi-label integration/E2E assertions.
  • Improve E2E session output collection and add a new programmatic session example.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
server/src/registry.rs Changes daemon listing filter to accept a labels map and apply AND logic.
server/src/lib.rs Updates PyO3 list_daemons signature to accept an optional labels dict.
README.md Updates docs terminology and quick-start snippets (server/daemon).
python/tests/test_unit.py Updates unit tests to call list_daemons(labels=...).
python/tests/test_integration.py Updates integration tests for label filtering, adds multi-label AND test.
python/tests/test_e2e.py Updates E2E label filtering calls; adds a same-daemon concurrency test; improves session multiline reading.
python/sandd/init.py Updates Python wrapper list_daemons signature/docs and call into Rust binding.
examples/programmatic_session.py Adds a new example showing programmatic session usage patterns.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread python/sandd/__init__.py
Comment thread python/sandd/__init__.py
Comment thread python/tests/test_e2e.py
Comment on lines +129 to +133
# Start slow command (3s) and fast command concurrently
with concurrent.futures.ThreadPoolExecutor(max_workers=3) as executor:
slow_future = executor.submit(run_sleep, 3)
fast_future = executor.submit(run_fast)

Comment thread python/tests/test_e2e.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants