feat: support more ops#5
Merged
Merged
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands the mlxcore::Array safe wrapper API to cover additional elementwise unary/binary operations and axis-specific reductions, aligning the Rust surface area more closely with the underlying MLX C API.
Changes:
- Add new unary ops on
Array:log,sin,cos,square,tanh. - Add new binary ops on
Array:power,maximum,minimum. - Add axis-specific reductions (
*_axes) via a new sharedreduce_axes_ophelper, plus unit tests covering the added ops.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/kind feature |
InftyAI-Agent
added
feature
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
crates/mlxcore/src/array.rs:520
tanhis added as a new unary op but isn’t covered by the newmore_unary_opstest (other new unary ops are). Adding at least one simple assertion (e.g., tanh(0)=0) would help prevent regressions in this binding.
assert_eq!(
b.negative(&s).unwrap().to_vec::<f32>(),
vec![1.0, -2.0, 3.0]
);
}
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
crates/mlxcore/src/array.rs:343
- The safety comment around
axes_ptris misleading: passing a null pointer does not make dereferencing safe. The key benefit here is avoiding passing a dangling pointer whenaxes.len() == 0; the C side still must not dereference the pointer whenaxes_num == 0. Updating the wording will prevent readers from assuming null makes dereferencing OK.
// For an empty slice `as_ptr()` is non-null but dangling; pass an
// explicit null pointer so the FFI call never hands C a bogus pointer
// even if it were to dereference it with `axes_num == 0`.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Member
Author
|
/lgtm |
InftyAI-Agent
added
the
lgtm
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
crates/mlxcore/src/array.rs:209
- Rust doesn’t have a
**operator, so this doc comment can be misleading for Rust API consumers. Consider rephrasing to describe the operation without implying an available operator.
/// Elementwise power: `self ** other`.
Comment on lines
+184
to
+187
| /// Elementwise natural logarithm. | ||
| pub fn log(&self, stream: &Stream) -> Result<Array> { | ||
| self.unary_op(stream, sys::mlx_log) | ||
| } |
Member
Author
|
/hold |
InftyAI-Agent
added
the
do-not-merge/hold
Member
Author
|
/unhold |
InftyAI-Agent
removed
the
do-not-merge/hold
InftyAI-Agent
approved these changes
Jul 21, 2026
InftyAI-Agent
left a comment
InftyAI-Agent
left a comment
Member
There was a problem hiding this comment.
Approved: PR has both lgtm and approved labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?