feat: add shape manipulation ops on Array#6
Open
kerthcet wants to merge 2 commits into
Open
Conversation
Signed-off-by: kerthcet <kerthcet@gmail.com>
InftyAI-Agent
added
needs-triage
Contributor
There was a problem hiding this comment.
Pull request overview
Adds shape-manipulation operations to mlxcore::Array and updates host extraction (to_vec) to correctly handle non-contiguous views by materializing a row-contiguous buffer first. This expands the safe Rust surface area over MLX-C’s shape/view operators and makes to_vec semantics consistent for transposed/broadcasted arrays.
Changes:
- Update
Array::to_vecto materialize a row-contiguous copy before reading via raw data pointers (fixing transpose/broadcast cases). - Add shape/view ops on
Array:contiguous,reshape,broadcast_to,transpose,squeeze,expand_dims. - Add unit tests covering reshape/transpose/broadcast/squeeze+expand_dims.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: kerthcet <kerthcet@gmail.com>
Comment on lines
+136
to
+139
| let contiguous = self.contiguous(&Stream::cpu()).unwrap_or_else(|e| { | ||
| panic!("to_vec: failed to make array contiguous: {e}"); | ||
| }); | ||
| contiguous.eval(); |
| pub fn expand_dims(&self, axis: i32, stream: &Stream) -> Result<Array> { | ||
| error::install(); | ||
| let mut out = unsafe { sys::mlx_array_new() }; | ||
| // SAFETY: handle/stream are valid; `op` writes the result into `out`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer
Does this PR introduce a user-facing change?