Skip to content

Add requirements.txt, missing patch to ASV benchmarks#331

Open
vchamarthi wants to merge 2 commits into
IntelPython:masterfrom
vchamarthi:asv-bench-pr
Open

Add requirements.txt, missing patch to ASV benchmarks#331
vchamarthi wants to merge 2 commits into
IntelPython:masterfrom
vchamarthi:asv-bench-pr

Conversation

@vchamarthi
Copy link
Copy Markdown
Contributor

  • Add _patch_setup.py that calls patch_numpy_fft() at worker import time with hard-fail validation (ensures benchmarks never silently run with stock NumPy)
  • Add requirements.txt with psutil and scipy benchmark dependencies
  • Update the regression threshold matching the mkl_umath

Copilot AI review requested due to automatic review settings June 5, 2026 15:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates the benchmarks setup to force NumPy’s FFT to run through Intel MKL (via mkl_fft) and tightens ASV regression thresholds.

Changes:

  • Add an import-time patch step that applies mkl_fft.patch_numpy_fft() during benchmark initialization.
  • Add a benchmarks requirements.txt with baseline dependencies.
  • Reduce ASV regressions_thresholds from 0.3 to 0.2.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
benchmarks/requirements.txt Adds benchmarks dependencies list for environment creation.
benchmarks/benchmarks/_patch_setup.py Implements mkl_fft patching with hard-fail checks and diagnostics.
benchmarks/benchmarks/init.py Calls the patch function during benchmark package import.
benchmarks/asv.conf.json Tightens regression threshold to catch smaller performance changes.

Comment thread benchmarks/requirements.txt
Comment thread benchmarks/benchmarks/_patch_setup.py
Comment thread benchmarks/benchmarks/_patch_setup.py Outdated
Comment thread benchmarks/benchmarks/_patch_setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants