Add requirements.txt, missing patch to ASV benchmarks#331
Open
vchamarthi wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the benchmarks setup to force NumPy’s FFT to run through Intel MKL (via mkl_fft) and tightens ASV regression thresholds.
Changes:
- Add an import-time patch step that applies
mkl_fft.patch_numpy_fft()during benchmark initialization. - Add a benchmarks
requirements.txtwith baseline dependencies. - Reduce ASV
regressions_thresholdsfrom0.3to0.2.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| benchmarks/requirements.txt | Adds benchmarks dependencies list for environment creation. |
| benchmarks/benchmarks/_patch_setup.py | Implements mkl_fft patching with hard-fail checks and diagnostics. |
| benchmarks/benchmarks/init.py | Calls the patch function during benchmark package import. |
| benchmarks/asv.conf.json | Tightens regression threshold to catch smaller performance changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_patch_setup.pythat callspatch_numpy_fft()at worker import time with hard-fail validation (ensures benchmarks never silently run with stock NumPy)requirements.txtwithpsutilandscipybenchmark dependencies