Feat: force dismiss captive signing#2
Open
virajpsimformsolutions wants to merge 2 commits into
Open
Conversation
Expo AsyncFunction handlers are dispatched on AsyncFunctionQueue (a non-main queue). DSMManager APIs (clearAllWebCookies, logout) must run on the main thread, so endSigningSession could touch them off-main and intermittently hang or crash. Hop to main before calling clearWebCookiesAsync. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
presentCaptiveSigningWithUrl presents the DocuSign signing WebView as a native modal above the app's view hierarchy. The SDK only dismisses it on the user's own Finish/Cancel — so a host app that tears down the session programmatically (e.g. a remote "end consultation" signal) cannot remove the modal: reset() resolved the JS promise but left the WebView on screen. reset() now dismisses the presented modal on the key window's root view controller. Gated on an in-flight signing (hadPending) so reset() never tears down an unrelated modal when no signing is active. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.