Skip to content

docs(openapi): document the five repo maintainer-report routes in the spec - #9412

Closed
bitfathers94 wants to merge 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-9302
Closed

docs(openapi): document the five repo maintainer-report routes in the spec#9412
bitfathers94 wants to merge 1 commit into
JSONbored:mainfrom
bitfathers94:fix/issue-9302

Conversation

@bitfathers94

Copy link
Copy Markdown
Contributor

docs(openapi): document the five repo maintainer-report routes in the spec

The maintainer-noise, ams-miner-cohort, gate-precision, outcome-calibration,
and activation-preview GET routes are all live and maintainer-authenticated with
an MCP tool counterpart, but none appeared in the generated OpenAPI spec.
MaintainerNoiseReport and AmsMinerCohortComparison were even registered as
components yet never attached to a path.

Add registerPath entries for all five, define GatePrecisionResponse,
OutcomeCalibrationResponse, and ActivationPreviewResponse schemas mirroring
their MCP tools' output shapes field-for-field, and regenerate the committed
openapi.json. A regression test asserts each path is documented with a 200
response referencing a component whose keys match its MCP tool shape.

Closes #9302

Validation

Verified locally on this branch before opening:

  • npm run typecheck
  • npx turbo run build:tsc build:verify
  • npm run test:coverage — patch coverage 100.0% of changed lines

@bitfathers94
bitfathers94 requested a review from JSONbored as a code owner July 27, 2026 16:53
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Important

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏳ LoopOver is waiting…

LoopOver has seen this pull request and is waiting on CI checks to finish before reviewing it. This comment will update once the review runs.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟨 Waiting

… spec

The maintainer-noise, ams-miner-cohort, gate-precision, outcome-calibration,
and activation-preview GET routes are all live and maintainer-authenticated with
an MCP tool counterpart, but none appeared in the generated OpenAPI spec.
MaintainerNoiseReport and AmsMinerCohortComparison were even registered as
components yet never attached to a path.

Add registerPath entries for all five, define GatePrecisionResponse,
OutcomeCalibrationResponse, and ActivationPreviewResponse schemas mirroring
their MCP tools' output shapes field-for-field, and regenerate the committed
openapi.json. A regression test asserts each path is documented with a 200
response referencing a component whose keys match its MCP tool shape.
@loopover-orb

loopover-orb Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This repository reviews pull requests one-shot: the PR must be correct as originally opened. Pushing an additional commit closes it automatically instead of restarting review — open a fresh pull request with every fix included.

@loopover-orb loopover-orb Bot added the review-evasion Gittensor contributor context label Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.08%. Comparing base (0a93e29) to head (14a8461).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9412      +/-   ##
==========================================
+ Coverage   75.51%   76.08%   +0.57%     
==========================================
  Files         275      278       +3     
  Lines       58032    59590    +1558     
  Branches     6209     6456     +247     
==========================================
+ Hits        43820    45342    +1522     
- Misses      13942    13955      +13     
- Partials      270      293      +23     
Flag Coverage Δ
backend 97.68% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/mcp/server.ts 97.13% <100.00%> (ø)
src/openapi/schemas.ts 100.00% <100.00%> (ø)
src/openapi/spec.ts 99.51% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review-evasion Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

openapi: 5 repo maintainer-report routes missing from spec (maintainer-noise, ams-miner-cohort, gate-precision, outcome-calibration, activation-preview)

1 participant