fix(api): document ai-review-findings pull request route in openapi spec - #9417
Conversation
Closes JSONbored#9305 The GET /v1/repos/{owner}/{repo}/pulls/{number}/ai-review-findings route existed and was live, but was never registered in the OpenAPI spec, unlike its maintainer-packet and reviewability siblings. Adds PullRequestAiReviewFindingsSchema, registers the path (including its login query param), and regenerates apps/loopover-ui/public/openapi.json.
…sue-9305-a1-openapi-pulls-number-ai # Conflicts: # apps/loopover-ui/public/openapi.json
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9417 +/- ##
===========================================
- Coverage 89.52% 75.64% -13.88%
===========================================
Files 840 277 -563
Lines 109777 58361 -51416
Branches 26147 8206 -17941
===========================================
- Hits 98275 44148 -54127
- Misses 10239 13942 +3703
+ Partials 1263 271 -992
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 18:02:26 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Decision record
Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|


Summary
The
GET /v1/repos/{owner}/{repo}/pulls/{number}/ai-review-findingsroute has existed for a while, but it was never registered in the OpenAPI spec — unlike itsmaintainer-packetandreviewabilitysiblings under the same/pulls/{number}/*path prefix.This adds the missing documentation:
PullRequestAiReviewFindingsSchemainsrc/openapi/schemas.ts, built from the route's actual response shape (reusing the same fields as the existingprAiReviewFindingsOutputSchemaMCP tool shape).src/openapi/spec.ts, including theloginquery parameter the route requires and its 400/403/404 responses.apps/loopover-ui/public/openapi.json(npm run ui:openapi).test/unit/openapi.test.tsso the path/schema can't silently disappear again.Closes #9305
Scope
src/openapi/**, the regeneratedopenapi.json, and its test.site//CNAME/VitePress touched.Validation
git diff --checknpm run typechecknpm run ui:openapi:checknpx vitest run test/unit/openapi.test.tsnpx vitest run --changed=upstream/main --passWithNoTests(136 files / 1736 tests passed, run after rebasing onto latest main)turbo run build --filter=@loopover/engine,--filter=@loopover/mcp,build:tsc build:verify --filter=@loopover/miner)Safety
UI Evidence
N/A — no visible UI change. This is purely an OpenAPI schema/path registration for an already-live backend route, plus the regenerated
openapi.jsonartifact.Notes
The route itself already existed with its access checks in place (
requireContributorAccess+assertContributorOwnsPullRequestinsrc/api/routes.ts); this PR only closes the documentation gap so it shows up in the OpenAPI contract like its siblings.