openapi: /v1/scoring/eligibility-plan + /v1/scoring/explain-breakdown missing from spec (MCP tools + schemas already exist) - #9421
Conversation
… missing from spec (MCP tools + schemas already exist) Fixes JSONbored#9301
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-27 18:05:02 UTC
Review summary Nits — 4 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. Decision record
Visual preview
Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy. Scroll preview
A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9421 +/- ##
==========================================
+ Coverage 75.51% 76.09% +0.58%
==========================================
Files 275 278 +3
Lines 58032 59610 +1578
Branches 6209 6456 +247
==========================================
+ Hits 43820 45362 +1542
- Misses 13942 13955 +13
- Partials 270 293 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
|


Summary
src/api/routes.tshas two live, tested/v1/scoring/*POST routes, each already backed by an MCPtool with its own Zod output shape in
src/mcp/server.ts:POST /v1/scoring/eligibility-plan→loopover_get_eligibility_plan(outputSchema: eligibilityPlanOutputSchema)POST /v1/scoring/explain-breakdown→loopover_explain_score_breakdown(outputSchema: scoreBreakdownOutputSchema)Neither route appears anywhere in
src/openapi/spec.ts— grep for"/v1/scoring/eligibility-plan"and
"/v1/scoring/explain-breakdown"in that file returns nothing, and neither route is reachablefrom the generated
apps/loopover-ui/public/openapi.json. Their sibling/v1/scoring/*routes(
/v1/scoring/model,/v1/scoring/preview) ARE documented. This is the same class of gap #6611fixed for
/v1/repos/{owner}/{repo}/gate-config/effective("OpenAPI spec is missing GET.../gate-config/effective (documented sibling: live-gate-thresholds)").
Deliverables
EligibilityPlanResponseSchemaandScoreBreakdownResponseSchemaadded tosrc/openapi/schemas.ts, matching the MCP tools' existing output shapes field-for-field.src/openapi/spec.ts.apps/loopover-ui/public/openapi.jsonregenerated vianpm run ui:openapiand committed.npm run ui:openapi:checkpasses in CI.All deliverables are required in this one PR — there is no follow-up issue.
Test plan
99%+ Codecov patch target (
codecov/patch, unsharded vianpm run test:coverage) on any new schemahelper code. Add a regression test (or extend an existing OpenAPI-spec snapshot/shape test) asserting
both new paths are present in
buildOpenApiSpec()'s output with the correct method and a responseschema whose keys match
eligibilityPlanOutputSchema/scoreBreakdownOutputSchema.Fixes #9301