fix(openapi): document validate-linked-issue + check-before-start (#9304) by wondercreatemaster · Pull Request #9443 · JSONbored/loopover

wondercreatemaster · 2026-07-27T18:50:10Z

Summary

Document POST /v1/repos/{owner}/{repo}/validate-linked-issue and POST /v1/repos/{owner}/{repo}/check-before-start in the OpenAPI contract — both routes were live (API + MCP) but missing from src/openapi/spec.ts / openapi.json.
Add MCP-aligned request/response schemas (ValidateLinkedIssue* / CheckBeforeStart*) matching validateLinkedIssueShape / checkBeforeStartShape and their output schemas in src/mcp/server.ts (owner/repo stay path params).
Regenerate apps/loopover-ui/public/openapi.json and add a field-parity regression test so future MCP/OpenAPI drift fails loudly.

Test plan

Single commit on latest main (includes docs(openapi): document the /v1/lint/* + /v1/validate/focus-manifest route family in the spec #9430 + openapi: 5 repo maintainer-report routes missing from spec (maintainer-noise, ams-miner-cohort, gate-precision, outcome-calibration, activation-preview) #9436)
npm run ui:openapi + npm run ui:openapi:check
npx vitest run test/unit/openapi.test.ts (9 passed)
CI validate / codecov/patch on the PR

…ONbored#9304) These two pre-work-check routes were live (API + MCP) but absent from the OpenAPI contract, so they never appeared in the generated openapi.json. Mirror the JSONbored#6611 / JSONbored#9301 pattern: MCP-aligned request/response schemas, registerPath entries, and a field-parity regression test.

superagent-security · 2026-07-27T18:50:44Z

Superagent didn't find any vulnerabilities or security issues in this PR.

loopover-orb · 2026-07-27T18:51:48Z

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-27 19:03:47 UTC}

5 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

safe to merge

Review summary
The PR correctly documents two new OpenAPI endpoints and their schemas, ensuring parity with MCP tool shapes. The test case verifies schema alignment, preventing drift between API and backend definitions. Changes are clean and follow existing conventions.

Nits — 2 non-blocking

Consider adding comments to the magic numbers (e.g., 300, 200) in schemas.ts to clarify their purpose (e.g., max length for strings).
Add a comment to the test case explaining why the schema property keys are filtered to exclude 'owner' and 'repo' (to match MCP tool shapes).

Decision drivers

✅ Code review — No blockers (1 reviewer)
✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#9304
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 33 registered-repo PR(s), 21 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	wondercreatemaster; Gittensor profile; 33 PR(s), 0 issue(s).
Improvement	✅ Minor	risk: clean · value: minor

Linked issue satisfaction

Addressed
The PR adds the required schemas to src/openapi/schemas.ts, registers both routes in src/openapi/spec.ts with matching request/response schemas, regenerates the UI's openapi.json, and includes a regression test verifying schema parity with MCP tools. All deliverables are fully implemented in a single PR.

Review context

Author: wondercreatemaster
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: not available
Official Gittensor activity: 33 PR(s), 0 issue(s).
PR-specific overlap: none found.

Contributor next steps

Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

@loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
@loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Decision record

action: merge · clause: success
config: d53ab30fb8a71bcaf13649d2496604c2199f49f4941adb51fe4e531844be3feb · pack: oss-anti-slop · ci: passed
record: 84c847592dfed1dcf51431fae73c3716327e8e458fa6c5c9b587181acc5e7d83 (schema v5, head 23d99f2)

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
`/`	desktop	_{before /}	_{after /}	—
`/`	mobile	_{before / (mobile)}	_{after / (mobile)}	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
`/`	_{before / (scroll)}	_{after / (scroll)}

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

Re-run LoopOver review

codecov · 2026-07-27T18:57:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.12%. Comparing base (fb8e2eb) to head (23d99f2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9443       +/-   ##
===========================================
- Coverage   89.54%   76.12%   -13.42%     
===========================================
  Files         843      278      -565     
  Lines      110011    59687    -50324     
  Branches    26184     6456    -19728     
===========================================
- Hits        98511    45439    -53072     
- Misses      10238    13955     +3717     
+ Partials     1262      293      -969

Flag	Coverage Δ
backend	`97.82% <100.00%> (+2.56%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/mcp/server.ts	`97.13% <100.00%> (ø)`
src/openapi/schemas.ts	`100.00% <100.00%> (ø)`
src/openapi/spec.ts	`99.62% <100.00%> (+<0.01%)`	⬆️

... and 703 files with indirect coverage changes

loopover-orb

LoopOver approves — the gate is satisfied and CI is green.

JSONbored

Merge conflicts, closing:

This branch has conflicts that must be resolved
Use the [web editor](https://github.com/JSONbored/loopover/pull/9443/conflicts) or the command line to resolve conflicts before continuing.

apps/loopover-ui/public/openapi.json

wondercreatemaster requested a review from JSONbored as a code owner July 27, 2026 18:50

github-actions Bot deployed to preview/pr-9443 July 27, 2026 18:52 View deployment

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 27, 2026

loopover-orb Bot assigned wondercreatemaster Jul 27, 2026

loopover-orb Bot approved these changes Jul 27, 2026

View reviewed changes

JSONbored reviewed Jul 27, 2026

View reviewed changes

JSONbored closed this Jul 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(openapi): document validate-linked-issue + check-before-start (#9304) - #9443

fix(openapi): document validate-linked-issue + check-before-start (#9304)#9443
wondercreatemaster wants to merge 1 commit into
JSONbored:mainfrom
wondercreatemaster:fix/9304-openapi-prework-checks-v3

wondercreatemaster commented Jul 27, 2026 •

edited

Loading

Uh oh!

superagent-security Bot commented Jul 27, 2026

Uh oh!

loopover-orb Bot commented Jul 27, 2026 •

edited

Loading

✅ LoopOver review result - approve/merge recommended

Uh oh!

codecov Bot commented Jul 27, 2026 •

edited

Loading

Uh oh!

loopover-orb Bot left a comment

Uh oh!

JSONbored left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wondercreatemaster commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

superagent-security Bot commented Jul 27, 2026

Uh oh!

loopover-orb Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ LoopOver review result - approve/merge recommended

Uh oh!

codecov Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

loopover-orb Bot left a comment

Choose a reason for hiding this comment

Uh oh!

JSONbored left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

wondercreatemaster commented Jul 27, 2026 •

edited

Loading

loopover-orb Bot commented Jul 27, 2026 •

edited

Loading

codecov Bot commented Jul 27, 2026 •

edited

Loading