Skip to content

upgrade gulp-git#30

Open
kimxogus wants to merge 2 commits into
JedWatson:masterfrom
kimxogus:master
Open

upgrade gulp-git#30
kimxogus wants to merge 2 commits into
JedWatson:masterfrom
kimxogus:master

Conversation

@kimxogus

@kimxogus kimxogus commented Jul 5, 2017

Copy link
Copy Markdown

gulp-git has require-dir@0.1.0 as a dependency, and require-dir@0.1.0 will fail with node v8.
So I upgraded gulp-git and fixed some code with happiness --fix.

@jorrit

jorrit commented Jul 14, 2017

Copy link
Copy Markdown

I hope @JedWatson can merge this PR soon.

@blacktemplar

Copy link
Copy Markdown

didn't see this pull request,

This solves issue #31

@paramaggarwal

Copy link
Copy Markdown

I hope @JedWatson can merge this PR soon.

@primaryobjects

Copy link
Copy Markdown

I can confirm this issue exists after upgrading to node v8.9.0.

Upgrading the version of gulp-git in package.json indeed resolves the issue.

"dependencies": {
  ..
  "gulp-git": "^2.4.1",
}

@palashkaria

Copy link
Copy Markdown

any chance this could get merged @JedWatson ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants