UI - optimize object allocations#3164
Merged
Oleksandr Karpovich (eymar) merged 22 commits intoJul 20, 2026
Merged
Conversation
…lections to avoid boxing, iterators and improve performance. (Similar change to PointerToPositionMap)
…e dirtyLayers.clear() inside the dirtyLayers.isNotEmpty() check as it does not make sense to clear if dirtyLayers is empty
…hod was iterating over a js value API in a kotlin loop and removing first child. This could cause freezes of up to 50 ms (observed during high-usage memory in a device). I observed a 5.8% reduction in time between main function call and Compose being composed, which amounted to around 7-8 ms (a frame, in my device). Also, the method used has been baseline since 2020 and it is the preferred way as it avoids crossing wasm to Js boundary over and over several times
…nstead Unspecified and Zero versions of it (compiles down to a simple primitive)
…init. (onPointerCallback was being created 6 times on init, delaying scene startup). It also avoid an iterator allocation on init
Apolo (ApoloApps)
marked this pull request as draft
June 28, 2026 22:15
… from the buildLongSet method instead of the outer extension function, causing the Set to be empty each time
Apolo (ApoloApps)
marked this pull request as ready for review
June 28, 2026 23:37
Author
|
Ivan Matkov (@MatkovIvan) separated changes that have nothing to do with graphics (the other changes are blocked until #3126 is merged) to at least unblock them from merging from #3117 |
| * This is used to avoid [Rect] object allocations on hot paths | ||
| */ | ||
| @Stable | ||
| internal inline fun IntSize.contains(offset: Offset): Boolean { |
Collaborator
There was a problem hiding this comment.
it seems semantically wrong - "contains" is not something that we can ask from size.
It might be just naming issues, but I'm not sure what fits better here
Author
There was a problem hiding this comment.
yep, I had the same dichotomy. encloses?? bounds??
if (size.bounds(offset)) bounds being used here as a verb
if (size.encloses(offset)) it is inferred (at least imo) that we are referring to the area between 0,0 and this Size's coordinates
Author
There was a problem hiding this comment.
renamed to bounds and updated KDoc. Done
Ivan Matkov (MatkovIvan)
requested review from
Oleksandr Karpovich (eymar) and
Igor Demin (igordmn)
July 8, 2026 07:27
…th more optimized Collections and more fast paths that avoid allocations
Igor Demin (igordmn)
changed the title
Collaborator
|
I changed the PR title to better reflect the changes |
Igor Demin (igordmn)
approved these changes
Jul 17, 2026
Collaborator
There was a problem hiding this comment.
LGTM. Oleksandr Karpovich (@eymar), please approve web changes and merge the PR
Oleksandr Karpovich (eymar)
approved these changes
Jul 20, 2026
Oleksandr Karpovich (eymar)
merged commit Jul 20, 2026
dbcdcad
into
JetBrains:jb-main
20 checks passed
Apolo (ApoloApps)
added a commit
to ApoloApps/compose-multiplatform-core
that referenced
this pull request
Jul 20, 2026
Separated the changes from JetBrains#3117 that don't involve graphics (which are currently blocked until separation of Skiko from Compose Ui and migration to Runtime Registration) as to unblock them from merging into main This includes changes SyntheticEventSender and more minor changes ## Release Notes N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separated the changes from #3117 that don't involve graphics (which are currently blocked until separation of Skiko from Compose Ui and migration to Runtime Registration) as to unblock them from merging into main
This includes changes SyntheticEventSender and more minor changes
Release Notes
N/A