Remove ComposeUiFlags.areWindowInsetsRulersEnabled#3211
Open
Vendula Švastalová (svastven) wants to merge 2 commits into
Open
Remove ComposeUiFlags.areWindowInsetsRulersEnabled#3211Vendula Švastalová (svastven) wants to merge 2 commits into
ComposeUiFlags.areWindowInsetsRulersEnabled#3211Vendula Švastalová (svastven) wants to merge 2 commits into
Conversation
… disableWindowInsetsRulers
Vendula Švastalová (svastven)
requested review from
Andrei Salavei (ASalavei),
Ivan Matkov (MatkovIvan) and
Oleksandr Karpovich (eymar)
July 10, 2026 13:21
Ivan Matkov (MatkovIvan)
requested changes
Jul 10, 2026
| * the application. This should be called before the first Compose root is created. | ||
| */ | ||
| @ExperimentalComposeUiApi | ||
| fun disableWindowInsetsRulers() { |
Collaborator
There was a problem hiding this comment.
Public API in commonMain is strictly no-go in fork. It will just crash on Android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
ComposeUiFlags.areWindowInsetsRulersEnabledin favor of commondisableWindowInsetsRulers()Fixes CMP-9823 Consider removing ComposeUiFlags.areWindowInsetsRulersEnabled flag
Prerequisity of merging this PR is that AOSP changes in the CL are merged and then synced into the fork.
Testing
testDisableWindowInsetsRulerstoWindowInsetsRulersTestRelease Notes
Features - Multiple Platforms
ComposeUiFlags.areWindowInsetsRulersEnabledin favor ofdisableWindowInsetsRulers()